Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible Update Support #2

Open
ysmoradi opened this issue Feb 23, 2024 · 15 comments
Open

Flexible Update Support #2

ysmoradi opened this issue Feb 23, 2024 · 15 comments
Assignees
Labels
blocked bug Something isn't working

Comments

@ysmoradi
Copy link

At the moment, we're using awesome Maui.AppStoreInfo in our project template
I tried to use Maui.Android.InAppUpdates, but I received exception related to exportable activities, but before trying to fix that issue, I'd like to know about porting to Xamarin.Google.Android.Play.App.Update's schedule.
Congrats on your awesome works! I really appreciate them (":

@HavenDV
Copy link
Collaborator

HavenDV commented Feb 23, 2024

Thanks for your feedback.
We tried using Xamarin.Google.Android.Play.App.Update already, but we had some problems with flexible updates, which is why we switched back to the Core package. I think we should give this another chance, the transition itself is quite trivial.

@HavenDV
Copy link
Collaborator

HavenDV commented Feb 23, 2024

Xamarin.Google.Android.Play.App.Update v2.1.0.5 gives this error when trying to build the final application. The library is built without errors

0>InstallStateUpdatedListener.java(4,8): Error JAVAC0000 javac:  error: InstallStateUpdatedListener is not abstract and does not override abstract method onStateUpdate(InstallState) in StateUpdatedListener
public class InstallStateUpdatedListener

0>InstallStateUpdatedListener.java(30,14): Error JAVAC0000 javac:  error: name clash: onStateUpdate(Object) in InstallStateUpdatedListener and onStateUpdate(InstallState) in StateUpdatedListener have the same erasure, yet neither overrides the other
	public void onStateUpdate (java.lang.Object p0)

Information:

@HavenDV HavenDV changed the title Migrating from Maui.AppStoreInfo to Maui.Android.InAppUpdates Xamarin.Google.Android.Play.App.Update support Feb 23, 2024
@HavenDV HavenDV changed the title Xamarin.Google.Android.Play.App.Update support Xamarin.Google.Android.Play.App.Update Support Feb 23, 2024
@HavenDV
Copy link
Collaborator

HavenDV commented Feb 23, 2024

So for now the planned solution to this issue is to just wait for the new version of Xamarin.Google.Android.Play.App.Update to be released and try again
But perhaps there are other possibilities to implement or bypass this and we will be grateful for any information

@HavenDV
Copy link
Collaborator

HavenDV commented Mar 7, 2024

Since support for Android 14 is important to us and the current version has bugs with this(xamarin/GooglePlayServicesComponents#813), we still made the transition and released version 1.1.0. But flexible updates are still not supported

@ysmoradi
Copy link
Author

ysmoradi commented Mar 9, 2024

It seems it's not compatible with popular Plugin.StoreReview nuget package, even the recently published beta version )":
As far as I was able to understand, this is mainly an issue of Plugin.StoreReview, not Maui.Android.InAppUpdates, but I think if you submit an issue to that repo, you can describe the situation much much better than me.

Error	XA4215	The Java type `com.google.android.play.core.install.InstallStateUpdatedListener` is generated by more than one managed type. Please change the [Register] attribute so that the same Java type is not emitted.	Boilerplate.Client.Maui	C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\34.0.52\tools\Xamarin.Android.Common.targets	1513	

@HavenDV
Copy link
Collaborator

HavenDV commented Mar 9, 2024

I think the main problem is that the packages using Xamarin.Google.Android.Play.Core are not compatible with the Xamarin.Google.Android.Play.App.Update packages and other modular packages. But I could be wrong here

@ysmoradi
Copy link
Author

ysmoradi commented Mar 9, 2024

I think the main problem is that the packages using Xamarin.Google.Android.Play.Core are not compatible with the Xamarin.Google.Android.Play.App.Update packages and other modular packages. But I could be wrong here

Would you recommend posting issue there?

@HavenDV
Copy link
Collaborator

HavenDV commented Mar 9, 2024

I see recent commits in this repository and maybe it makes sense. Otherwise we may release a similar package for net8 and higher

@HavenDV
Copy link
Collaborator

HavenDV commented Mar 9, 2024

Or I can provide a PR with support for migrating to modular packages for that repository and we'll just use that. But this may have compatibility issues with previous versions

@ysmoradi
Copy link
Author

I'm fine with either approaches
If you decided to send a PR, consider opening issue there first, so we can continue discussion there.
Hope this helps me use your package in our project template finally 😅

@HavenDV
Copy link
Collaborator

HavenDV commented Mar 12, 2024

https://github.com/oscoreio/Maui.InAppReviews
I've already released an initial version of this package, but I haven't tested it enough yet. But any feedback if you have time to test this would help me

@ysmoradi
Copy link
Author

Greeting!
It's working.
The only remaining issue is support for flexible updates.

@HavenDV
Copy link
Collaborator

HavenDV commented Mar 30, 2024

Version	Downloads	Last updated	
[2.1.0.6](https://www.nuget.org/packages/Xamarin.Google.Android.Play.App.Update.Ktx/2.1.0.6)	40	2 days ago

I hope this update that came out two days ago will solve the problem

@ysmoradi
Copy link
Author

ysmoradi commented May 3, 2024

Any updates on this? 😭

@HavenDV
Copy link
Collaborator

HavenDV commented May 3, 2024

This new version of the package still gives the same error, so unfortunately no
The only way I see is to take the source code of this package and fix it, but I'm not quite sure where this source code is, whether it's open source, I didn't find it in their repository

@HavenDV HavenDV changed the title Xamarin.Google.Android.Play.App.Update Support Flexible Update Support May 24, 2024
@HavenDV HavenDV added bug Something isn't working blocked labels May 24, 2024
@HavenDV HavenDV self-assigned this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants