Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.10 RC3 - issue report - "Data Integrity"-Label (ticket form) is missing in field configuration window #3194

Closed
ghost opened this issue Jun 12, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented Jun 12, 2016

When you configure a field for the ticket form and you are in the settings tab, you will see that this label is missing:

required to close a thread

I guess this has something to do with the file dynamic-field-config.tmpl.php in include/staff/templates.

Line 102 seems to be the source of the problem:

<div class="span4"> <div style="margin-bottom:5px"><strong><?php __('Data Integrity'); ?></strong> <i class="help-tip icon-question-sign" data-title="<?php echo __('Required to close a thread'); ?>" data-content="<?php echo __('Optionally, this field can prevent closing a thread until it has valid data.'); ?>"></i> </div> </div>

This is the corresponding part for the Editable-Label to compare:

<div class="span4"> <div style="margin-bottom:5px"><strong>Editable</strong> <i class="help-tip icon-question-sign" data-content="<?php echo __('Fields marked editable allow agents and endusers to update the content of this field after the form entry has been created.'); ?>" data-title="<?php echo __('Editable'); ?>"></i> </div> </div>

Normally the Label is between the strong tags, in this line there is no label, only this code "" .

By the way: I'm very excited because of the new releases from osticket.com: 1.10 RC3 and 1.9.14. 👍
Thank you very much @greezybacon @protich !

@ghost ghost changed the title 1.10 RC3 - issue report - "Required to close a thread"-Label is missing in field configuration windows 1.10 RC3 - issue report - "Required to close a thread"-Label is missing in field configuration window Jun 12, 2016
Chefkeks added a commit to Chefkeks/osTicket-1.8 that referenced this issue Jun 12, 2016
@ghost
Copy link
Author

ghost commented Jun 20, 2016

Adding "echo" in line 102:

<div style="margin-bottom:5px"><strong><?php echo __('Data Integrity');

..seems to solving the problem:

data integrity

@ghost ghost changed the title 1.10 RC3 - issue report - "Required to close a thread"-Label is missing in field configuration window 1.10 RC3 - issue report - "Data Integrity"-Label (ticket form) is missing in field configuration window Jun 20, 2016
@greezybacon
Copy link
Contributor

@mfelber thanks for the hint. I fixed the issue directly

@thuc960
Copy link

thuc960 commented Oct 12, 2016

Thanks

kurtbr pushed a commit to kurtbr/osTicket that referenced this issue Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants