-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.9.7 - Strange issue with Backspace key & draft saving #2373
Comments
I got similar complaints from my agents with osticket 1.9.11 (and 1.9.8.1) in combination with firefox 39. It is not so easy to replicate this (at least for me). They use it the whole day and writing much faster than me and they can reproduce it multiple times a day. In our case the cursor disappears suddenly (when using backspace during the writing) and the writing of text continues at the first position of the redactor window. This is my environment: osTicket-Version v1.9.11 (c1b5a33) — Up to date |
i have the same problem in v 1.9.11 |
Same issue. Version 1.9.11, Firefox 39.0.3. It;s driving me insane. As a temporary fix I installed noscript. Not the best solution but at least now I can type. |
I can confirm first hand the issue still exists in Firefix 40.0.2 |
I think this issue might be solved with version 10.2.3 of Redactor, which was released on August 15. Changelog includes:
|
I agree. I saw that fix and will work on upgrading redactor in osTicket-1.8 develop-next |
Where to get a fix for the problem? I use v1.9.12 and the problem still exist. |
As you can see will be the fix the implementation of a newer redactor version in osTicket 1.10 (osTicket-1.8 develop-next). So you will have to wait until 1.10 is stable or as a workaround use a different browser.. |
+1 |
Very terrible! I have loosed a ticket reply for that because write my response to a ticket was very difficoult... so i switched to non HTMl by the button <> and when sended the reply all my text was loost, not sent and not visible again by pressing back button. I AM also waiting the 10 relase as solve also the issue with registration link who not work if the user is logged as guest and are viewinf ticket So two beautiful issue to resolve with the new version, hope can be relased soon. |
When to expect a working solution for the editor problem? |
Right question :) is not a small issue... is very hard to manage tickets. |
This is a pretty major issue, I understand that 1.10 has a lot of new stuff in it, would it be possible to just make a point release of 1.9 to fix this bug? OSTicket is pretty much impossible to use with Firefox if rich-text is enabled, so we've been forced to turn it off. |
1.9.12 and have this too, its driving some of the staff nuts.. |
Perhaps too early to cheer, following the instructions of Draconis, on the website of osticket, i believe our osticket was fixed. On line 308 of redactor-osticket.js located in folder js of your osticket installation : On a sidenote: |
Thanks for share @rjboer |
That didn't quite cut it, the editor still loses focus... (only focus this time, it does not reset itself to the beginning of the line, seen only one error) Be aware to restart apache..for changes to come through However, i think it has something to do with the following.....
restore
|
Hi guys, |
The v1.10 branch ( |
Great news! This is really driving me crazy :) |
We're poised to make an rc3 release. It's proving pretty stable, so that will likely be the final release candidate release |
Thumbs up! |
It looks like 1.9 branch has had two interim patches I didn't see, .13 & .14, anyone tested these yet to see if it resolves this issue? |
My hacked file, the bug fixed :) https://gist.github.com/cosmospham/78974d588805fc3cc9b8c3deac71f54d |
@comfine have you tried msigley's patch? try it in a private session to avoid using a cached version. I can confirm it's still happening on develop with the latest firefox Steps to reproduce
Expected behaviorA character gets deleted. Actual behaviortextarea loses focus and your input does not go in. |
@rayfoss I was writing a response to this yesterday and apparently I never hit save. I believe this is actually two issues, buggy redactor, which I believe the 10.2.5 update helps with but doesn't eliminate and draft saves and deletions broken due to older mysql logic and MariaDB. The workaround I found for the draft issue can be found in this issue report: |
The real fix for this issue is to replace redactor with a more FOSS friendy editor like tinymce, but this is gonna be alot of work. |
msigley: i tried the fix you posted in #3193, and also, i installed the redactor update/fix posted by you, but i still have problems with a jumping cursor (just some minutes ago the cursor jumped two rows down while i was typing inside a already written text). :-( |
Firefox? You could try using chrome.
Get Outlook for Android
On Sat, Feb 11, 2017 at 7:24 AM -0500, "comfine" <notifications@github.com> wrote:
msigley: i tried the fix you posted in #3193, and also, i installed the redactor update/fix posted by you, but i still have problems with a jumping cursor (just some minutes ago the cursor jumped two rows down while i was typing inside a already written text). :-(
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Of course WE could use another browser, but do you agree, that we cannot force all the customers to use another browser!? |
Is your firefox up to date? Maybe you could starr working on replacing redactor with tinymce? |
we are using the ESR-Release, but our customer had the same Problem with the newest Firefox-Version! ...my attempts to contribute some code were not sucessfully in the past, but i would love it to support the OS-Ticket-project, but right now we have to close almost 200 Tickets (with a very small team) before i could spend some time for other things :-( |
I also would like this fixed. I'm NOT happy with Chrome so I won't change to it only for Osticket because then I get other issues with other things. |
I do not like Chrome too. I love Firefox :D |
@msigley thanks for sharing that. |
i am sorry, but we are using 10.2.5 and the problem is still present! i reported the bug at redactor now. |
I AM using this solutions: #2373 (comment) |
@PeopleInside Which Firefox-Version do you use? |
Firefox 53 |
We have 52.0.2 - problem occured yesterday last time... i updatet to 53 now, but i suppose, it'll happen again. The bug i opened at the github-link from bogdandanielb was closed, as this was just a php-widget, not redactor by itself...so there's no hope from this site, that something will change. @PeopleInside - it is very interesting, that you can not see this bug anymore at your setup, while we still do! can you provide detail-information? is your firefox 32 or 64 bit? which OS do you use? have you disabled the "autosave-Draft"-function? |
No but maybe some issue continue to be... I was having an issue that in the time I was write a message cursor sometimes went moved... I solved this issue. |
I think that BUG appear when a popup "Draft saved" is opens, may be he taken cursor focus? Before that popup, backspace work normal. |
@PeopleInside it would be helpful if you could tell us, which OS you use, which Bit-Version of FF you use, i suppose, you said "NO" regarding my question if you disabled the autosave-drafts-function, is that right? |
Are you able to see the cursor issue also in visitor side? |
@PeopleInside i wrote you at gitter without response... anyway, again over here: i could see the problem at client-side aswell, yes, but maybe this was before i applied the new redactor-version - i am not sure about this. it would be really interesting which OS you use and which FF-bit-Version. if you are 100% sure, that the problem is fixed at your side something different or additional then the patch must be still causing this issue! PS: i reloaded the ostickets-backend now by pressing STRG+F5 - maybe the old JS-File was still in the cache and maybe this caused the issue - i will report back.... |
@comfine my current setup is the following:
The issue I had was on Agent panel when responding to existing tickets and pressing backspace. |
@bogdandanielb i could see, that it happened always at the same position. in my text has been two ! - and when i wanted to write a letter before this, some problem occured, multiple times ( i don't remember exactly if the cursor was jumping, or if the pressed letters didnt appear....) - there seem to be some other bugs in Redactor 10.2.5 aswell. :-( ....so the only solution, as this is closed source now... would be to replace the WYSIWYG-Editor ...or fork the last version and fix the problem... but i am not that good in JS and i dont have the time :-( i posted in the other thread this morning: @PeopleInside: can you please tell me which OperatingSystem you use? |
@comfine I had that issue too where the cursor was moving to a different location when trying to add additional words to existing text. I cannot seem to reproduce that issue anymore. This was in addition to the backspace issue which was triggered usually when using this key after a space. |
@bogdandanielb i am sorry, i cannot reproduce like you - if it'll be reproducable in any case i will try to capture a video.... our environment: |
@bogdandanielb You are reading that change log wrong. OSTicket uses the original Redactor, not Redactor II (closed source version) which is what that change log is for. Redactor switched to closed source around July 2015: Redactor 10.2.5, which we both found at the link below, appears to be the last unofficial publicly available update to Redactor, which is why I suggested the only real fix to these issues is to replace Radactor with a another WYSIWYG editor that is FOSS. TinyMCE is probably the best choice given its widespread use in Wordpress. |
@msigley You are correct, that change log was a bit misleading for me. |
why are all these bugs simply closed? they are still persist and still annoying! |
I've had multiple staff members complain that pressing the backspace key while the "Save Draft" message is up causes the cursor to skip back to the first position (row 1 col 1) and is very frustrating to them as they're typing out a message. We've made no changes to the server or software. As we're still on a (slightly) older 1.9.7 I can only attribute it to something in one of the JS libraries, or a change in browser behavior with said JS. So for the only offender seems to be FireFox.
Seems to be similar, though not exactly the same as #2322
The text was updated successfully, but these errors were encountered: