Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSN environmental variable is not set optionally #659

Closed
3 of 5 tasks
blumTom opened this issue Dec 24, 2023 · 2 comments
Closed
3 of 5 tasks

DSN environmental variable is not set optionally #659

blumTom opened this issue Dec 24, 2023 · 2 comments
Labels
bug Something is not working.

Comments

@blumTom
Copy link

blumTom commented Dec 24, 2023

Preflight checklist

Ory Network Project

No response

Describe the bug

Location:

{{- if not (empty ( include "kratos.dsn" . )) }}

The condition does not evaluate properly.
The intention here is to set the DSN environmental variable optionally, but with this condition it is always set.
However, it is a good idea to set the DSN environmental variable optionally to give the user the possibility to define a custom source of this value via the "cleanupCronjobExtraEnv" variable.
In addition to that this should be consistent to all other occurrences of DSN environmental variable definitions.

Reproducing the bug

Do not set the dsn config value.

Relevant log output

No response

Relevant configuration

dsn:

Version

0.38.0 (helm version)

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response

@blumTom blumTom added the bug Something is not working. label Dec 24, 2023
@blumTom blumTom mentioned this issue Dec 24, 2023
6 tasks
@dlahn
Copy link
Contributor

dlahn commented May 15, 2024

fixed by #678

@Demonsthere
Copy link
Collaborator

closed by #678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

3 participants