Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ory hydra dsn configuration through existing secret causes env var to not be defined #655

Open
3 of 5 tasks
zyixc opened this issue Nov 29, 2023 · 1 comment
Open
3 of 5 tasks
Labels
bug Something is not working.

Comments

@zyixc
Copy link

zyixc commented Nov 29, 2023

Preflight checklist

Ory Network Project

No response

Describe the bug

DSN environment not defined for the deployments, jobs and cronjobs.

Reproducing the bug

Predefining the hydra secret with the dsn value and not providing hydra.config.dsn omits the following environment variable.

This change was introduced here: #509. I do not think this was intended, if hydra.config.dsn or demo are both not provided it can just be included. As this is a list of environment variables, later definitions can override the value.

Relevant log output

level=fatal msg=dsn must be set audience=application service_name=Ory Hydra service_version=v2.1.2

Relevant configuration

No response

Version

0.37.0

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

For now this is needed

    secret:
      enabled: false
      nameOverride: hydra
    deployment:
      extraEnv: 
         - name: DSN
            valueFrom:
              secretKeyRef:
                name:  hydra
                key: dsn
@zyixc zyixc added the bug Something is not working. label Nov 29, 2023
@Demonsthere
Copy link
Collaborator

Hello there, can you please verify if this case still doesn't work as expected on the latest release/master? We did merge some changes to DSN handling, which should unify the setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

2 participants