Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydra Maester chart does not allow env variables, but maester v0.0.31 requires it #650

Open
3 of 5 tasks
WoodyWoodsta opened this issue Nov 9, 2023 · 0 comments
Open
3 of 5 tasks
Labels
bug Something is not working.

Comments

@WoodyWoodsta
Copy link

Preflight checklist

Ory Network Project

No response

Describe the bug

ory/hydra-maester#125 introduces the ability to customise the client secret keys via environment variables, however, the changes needlessly (and unfortunately) breaks the existing default keys meaning that upgrading an existing deployment produces errors client_id property missing.

There is no way to specify these new environment variables with the helm chart, forcing users to have to manually update the secrets to match the default keys.

Reproducing the bug

Upgrade hydra-maester to at least v0.0.31.

Relevant log output

2023-11-09T09:53:13Z	ERROR	controllers.OAuth2Client	secret *** is invalid	{"error": "client_id property missing"}
github.com/ory/hydra-maester/controllers.(*OAuth2ClientReconciler).Reconcile
	/home/runner/work/hydra-maester/hydra-maester/controllers/oauth2client_controller.go:194
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:118
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:314
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:265
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:226
2023-11-09T09:53:13Z	ERROR	controllers.OAuth2Client	error processing client *** 	{"oauth2client": "register", "error": "client_id property missing"}
github.com/ory/hydra-maester/controllers.(*OAuth2ClientReconciler).updateReconciliationStatusError
	/home/runner/work/hydra-maester/hydra-maester/controllers/oauth2client_controller.go:360
github.com/ory/hydra-maester/controllers.(*OAuth2ClientReconciler).Reconcile
	/home/runner/work/hydra-maester/hydra-maester/controllers/oauth2client_controller.go:195
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:118
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:314
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:265
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:226

Relevant configuration

No response

Version

N/A

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Kubernetes with Helm

Additional Context

No response

@WoodyWoodsta WoodyWoodsta added the bug Something is not working. label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

1 participant