Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test NumPy 2.0 compatibility #301

Closed
ortk95 opened this issue Oct 16, 2023 · 2 comments · Fixed by #344
Closed

Test NumPy 2.0 compatibility #301

ortk95 opened this issue Oct 16, 2023 · 2 comments · Fixed by #344
Labels
upstream Issue caused by upstream code, dependencies etc.

Comments

@ortk95
Copy link
Owner

ortk95 commented Oct 16, 2023 •
edited

We should test that everything works properly with NumPy 2.0 once it's released, then remove the explicit numpy<2.0 from requirements.txt and setup.py.

See also:
@ortk95 ortk95 added the upstream Issue caused by upstream code, dependencies etc. label Oct 16, 2023
@ortk95
Copy link
Owner Author

ortk95 commented Feb 15, 2024 •
edited

  • Should also deal with this kind of thing (from test log):

/home/runner/work/planetmapper/planetmapper/planetmapper/observation.py:671: DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)

@ortk95 ortk95 mentioned this issue Mar 13, 2024
Merged
5 tasks
@ortk95 ortk95 linked a pull request Mar 15, 2024 that will close this issue
Update PlanetMapper for compatibility with NumPy 2.0 #344
Merged
5 tasks
@ortk95
Copy link
Owner Author

ortk95 commented Apr 4, 2024

Seems like we just need to wait for astropy 6.1.0 before we have full numpy 2.0 support now.

@ortk95 ortk95 closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream Issue caused by upstream code, dependencies etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PlanetMapper for compatibility with NumPy 2.0 ortk95/planetmapper
1 participant
@ortk95