Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on Node 18 #121

Closed
kerberjg opened this issue Sep 14, 2022 · 2 comments
Closed

Broken on Node 18 #121

kerberjg opened this issue Sep 14, 2022 · 2 comments

Comments

@kerberjg
Copy link

Whenever I try to send emails via this module from my application on Node >= 18, I get the following error:

(node:23783) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

[Error: Bad Request] {
  status: 400,
  details: { message: 'from parameter is missing' }
}

Simply changing the Node version to 12 or 14 mitigates this, but it's not something we can use in production as we need the features of Node 18 for our project.

This is not a duplicate of #116, as in this case the email does not send at all, however the fix for both issues would be to simply upgrade the mailgun.js dependency. This module is currently depending on v3.3.0, while v8 is available.

sam-lord added a commit to sam-lord/nodemailer-mailgun-transport that referenced this issue Sep 14, 2022
refs: orliesaurus#121

Latest version of mailgun.js is needed for node 18.

Adding node types fixes the error seen when running `npm i`
@orliesaurus
Copy link
Owner

@kerberjg - with the latest updates merged in and thank you sam-lord this should be fixed!

@kerberjg
Copy link
Author

kerberjg commented Oct 3, 2022

Neat! Thanks a lot 😄✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants