Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expandable sections from readme don’t render correctly on website #163

Open
ZevEisenberg opened this issue Jan 2, 2024 · 4 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@ZevEisenberg
Copy link

Describe the bug

At https://halp.cli.rs, there are two expandable sections: Table of Contents and Packaging status. These sections also exist in the project’s Readme on GitHub. In the Readme, the expanded sections look right. But on the website, they are displayed as raw Markdown instead of formatted HTML.

To reproduce

  1. Go to https://halp.cli.rs.
  2. Click the Table of Contents and Packaging status sections to expand them.

Expected behavior

GitHub:

Formatted list and images, respectively, as we see on the GitHub readme version of the same sections:

image image

Screenshots / Logs

Website:

image image

Software information

  • Operating system: Safari 17.2.1 (19617.1.17.11.12) on macOS 14.2.1 (23C71)
  • Rust version: N/A
  • Project version: N/A

Additional context

Happy new year!

@ZevEisenberg ZevEisenberg added the bug Something isn't working label Jan 2, 2024
@ZevEisenberg
Copy link
Author

I wanted to submit a PR to fix this, but I couldn’t tell if the GitHub Pages instance is sourced from this repo or another one.

@orhun
Copy link
Owner

orhun commented Jan 2, 2024

Thanks for reporting this issue and happy new year!

I wanted to submit a PR to fix this, but I couldn’t tell if the GitHub Pages instance is sourced from this repo or another one.

It is hosted from this repository and it is based on Jekyll - and it kinda sucks. I tried to customize the CSS at some point in the past but it turned out to be more work than I was expecting.

Unless you have another idea, the most straightforward thing to do would be changing the theme to something that supports expandable sections. You can check out the themes here: https://pages.github.com/themes/

Or we can straight-up remove those sections from the website, see this workflow for an example.

What do you think?

@ZevEisenberg
Copy link
Author

There doesn't seem to be a way to easily check if those themes support expandable sections, and I don't have time to pull down the repo, get jekyll running locally, and try them all. But I bet that's the easiest way forward. Or deleting the TOC and un-collapse the packaging status 🤔. GitHub generates a TOC for you now, although it is a little hidden, but you might not need to do it manually any more.

@orhun
Copy link
Owner

orhun commented Jan 2, 2024

Yeah it is a little annoying to deal with 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants