org-roam-graph--build-connected-component does not respect org-roam-graph-exclude-matcher

[kalkin]

Description

The title says it all.

Steps to Reproduce

1. (setq org-roam-graph-exclude-matcher '("refs"))
2. Create refs/something.org
3. Reference refs/something.org from JOURNAL.org
4. call org-roam-graph with the universal argument 2 (org-roam-graph--build-connected-component is called)
5. Graph includes a backlink to refs/something.org

Expected Results

No graph link to refs/something.org

Actual Results

Graph link to refs/something.org

Environment

• Emacs: GNU Emacs 27.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.16)
  of 2020-06-03
• Framework: Doom
• Org: Org mode version 9.4 (nil @ /home/USER/.emacs.d/.local/straight/build/org-mode/)
• Org-roam: 1.1.1

[zaeph]

I cannot reproduce this. Could you update Org-roam and try again?

[kalkin]

I still can reproduce it with the latest Doom Emacs + Org-Roam version which is provided by it.

Here is the output of doom info

((emacs
  (version . "27.0.91")
  (features . "XPM JPEG GIF PNG RSVG DBUS GLIB NOTIFY INOTIFY GNUTLS LIBXML2 FREETYPE HARFBUZZ XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD JSON PDUMPER GMP")
  (build . "Jun 03, 2020")
  (buildopts "--prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-silent-rules --docdir=/usr/share/doc/emacs-27.0.91 --htmldir=/usr/share/doc/emacs-27.0.91/html --libdir=/usr/lib64 --program-suffix=-emacs-27-vcs --includedir=/usr/include/emacs-27-vcs --infodir=/usr/share/info/emacs-27-vcs --localstatedir=/var --enable-locallisppath=/etc/emacs:/usr/share/emacs/site-lisp --without-compress-install --without-hesiod --without-pop --with-dumping=pdumper --with-file-notification=inotify --disable-acl --with-dbus --with-modules --without-gameuser --with-libgmp --without-gpm --with-json --without-kerberos --without-kerberos5 --without-lcms2 --with-xml2 --without-mailutils --without-selinux --with-gnutls --with-libsystemd --with-threads --without-wide-int --with-zlib --with-sound=no --with-x --without-ns --without-gconf --without-gsettings --with-toolkit-scroll-bars --with-gif --with-jpeg --with-png --with-rsvg --without-tiff --with-xpm --without-imagemagick --with-xft --without-cairo --with-harfbuzz --without-libotf --without-m17n-flt --with-x-toolkit=gtk3 --with-xwidgets 'CFLAGS=-march=native -pipe -Wl,-O1 -Wl,--as-needed -O2' CPPFLAGS= 'LDFLAGS=-Wl,-O1 -Wl,--as-needed'")
  (windowsys . batch)
  (daemonp . server-running))
 (doom
  (version . "2.0.9")
  (build . "HEAD -> develop dd8b535eb 2020-06-08 01:39:49 -0400")
  (dir . "~/.doom.d/"))
 (system
  (type . gnu/linux)
  (config . "x86_64-pc-linux-gnu")
  (shell . "/bin/zsh")
  (uname . "Linux 5.6.15-gentoo #1 SMP PREEMPT Thu May 28 14:06:46 CEST 2020 x86_64")
  (path "~/.gem/ruby/2.5.0/bin" "~/.cargo/bin" "~/.perl6/bin" "~/bin" "~/.local/bin" "/usr/local/sbin" "/usr/local/bin" "/usr/sbin" "/usr/bin" "/sbin" "/bin" "/usr/lib/llvm/10/bin" "~/opt/GNAT/current/bin" "/usr/libexec/emacs/27.0.91/x86_64-pc-linux-gnu"))
 (config
  (envfile)
  (elc-files . 0)
  (modules :completion company helm :ui deft doom doom-dashboard doom-quit hl-todo modeline ophints (popup +defaults) pretty-code vc-gutter vi-tilde-fringe workspaces :editor (evil +everywhere) file-templates fold (format +onsave) snippets :emacs dired electric undo vc :checkers syntax spell grammar :tools (eval +overlay) lookup lsp magit :lang (cc +lsp) data emacs-lisp json markdown (org +roam) sh :config (default +bindings +smartparens))
  (packages (solarized-theme) (org-ref) (org-jira :recipe (:host github :repo "ahungry/org-jira")))
  (unpin "n/a")
  (elpa "n/a")))

[zaeph]

This might be linked to #452, but I'm still suspecting a problem with the version of the packages. Make sure that none of them are pinned to a specific version.

@bdarcus: Could you verify/assist with this?

[bdarcus]

The doom/straight update bug, and workaround, is described here.

[kalkin]

#452 fixes the issue described in the title. I looked at the exact same line of code and was too lazy to figure out how the lisp + sqlite query syntax, or whatever happens there works.

[kalkin]

@zaeph & @bdarcus Thank you for your help