Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download pdf files using helm-bibtex and biblio.el #176

Open
leoc opened this issue Mar 2, 2021 · 2 comments
Open

Download pdf files using helm-bibtex and biblio.el #176

leoc opened this issue Mar 2, 2021 · 2 comments
Labels
1. enhancement New feature or request

Comments

@leoc
Copy link

leoc commented Mar 2, 2021

Is your feature request related to a problem? Please describe.
I am using helm-bibtex and biblio.el which allows an extended download action to retrieve the pdf from arXiv.
The issue is, that the file is wrongly named and saved to the org-directory.

2021-03-02-111151_2037x1368_scrot

Describe the solution you'd like
I would like the filename to adhere to the file name convention of org-ref and org-roam-bibtex (including the autokey pattern).

  (setq orb-autokey-format "%a%y")

Additional context
I have looked at biblio.el at https://github.com/cpitclaudel/biblio.el/blob/55a72b5cd41325d8c98a73932ef3a7b0cf71ea63/biblio-download.el#L37

I don't know how you would imlement this. I would have overwritten the function of biblio and adjusted the file name according to the rest of the configuration. I wondered whether there is a function ready to use to convert the record from biblio to a citation key. Since you are pulling from different libraries already, I thought it would make sense to ask this question here.

Much love and thanks for the packages!

@myshevchuk
Copy link
Member

Hi! Thank you for your request. Although, it's not directly related to ORB and I don't have any influence on biblio.el, org-ref and helm-bibtex of course, the request becomes interesting after some rephrasing. I will consider it as a feature request to provide a way to download pdf files associated with the current note, via orb-note-actions. The backend tools will be the same - helm-bibtex and biblio.el, but when called through orb-note-actions, they will do the right job. The vanilla helm-bibtex and biblio.el will not be changed - it's never a good idea for a package to patch another package, unless it's the package's main task. If you want to override these functions directly, you must do it in your config.

Unfortunately, I'm currently a little bit short on time, so can't promise it will be done quickly.

@myshevchuk myshevchuk changed the title Fix download location of biblio.el when using helm-bibtex download action Download pdf files using helm-bibtex and biblio.el Mar 2, 2021
@myshevchuk myshevchuk added the 1. enhancement New feature or request label Mar 2, 2021
@leoc
Copy link
Author

leoc commented Mar 3, 2021

Hey! Thank you for your quick answer. Much appreciated!

I could help if get a little nudge in the right direction. I will look through the source to find out how you integrate the various packages. I hope to find some time this weekend :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants