Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Max" appears to be unrelated to the actual graph #115

Open
jwalton opened this issue Dec 2, 2020 · 2 comments
Open

"Max" appears to be unrelated to the actual graph #115

jwalton opened this issue Dec 2, 2020 · 2 comments

Comments

@jwalton
Copy link

jwalton commented Dec 2, 2020

image

According to this the "max" is 37ms, but looking at the graph we can clearly see several spikes up into 50ms range. The demo gif in the README.md has this same problem.

@thepacketgeek
Copy link
Contributor

I was just digging into this, nice eyes! I suspect it's a matter of aliasing or rounding on the part of the tui::Chart widget. I'm not seeing the values in the histogram matching what's being displayed, so it doesn't seem like an issue with the data calculation:

Screen Shot 2020-12-02 at 9 27 36 AM

@thepacketgeek
Copy link
Contributor

ah yup, it's weirdness with the label rendering and not the data itself. I have an approximate fix in #116 , the math here is interesting with the Chart padding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants