Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to hide the overlay if consent has already been given #45

Open
MoritzLost opened this issue Jul 17, 2023 · 0 comments
Open
Labels
enhancement New feature or request
Milestone

Comments

@MoritzLost
Copy link

Follow-up to the discussion in #10

Some external content may require external resources to load before it can be displayed, some will be visible almost immediately. In the first case, showing the overlay and then fading it out (the current behaviour) makes sense. But if the external content will be displayed immediately, having the overlay just show up very briefly and then fade out immediately doesn't look great, it looks more like a bug to the users.

As a solution, I suggest an optional option (either for the entire library or for individual services) to adjust this behaviour. If activated, the option should change the behaviour as followed:

  • If no consent has been given for the service, the overlay should be displayed normally and fade out as it currently does.
  • If consent has already been given for the service when the library is initialized, the library should skip showing the overlay and immediately reveal the external content (and call the onAccept callback).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants