Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly preprocessor (rpp) improvements #497

Open
jhand2 opened this issue Oct 29, 2021 · 4 comments
Open

Assembly preprocessor (rpp) improvements #497

jhand2 opened this issue Oct 29, 2021 · 4 comments
Labels
Feature Request Feature Request Good First Issue Good for newcomers

Comments

@jhand2
Copy link
Contributor

jhand2 commented Oct 29, 2021

rpp does not currently support multiline macros such as

#define MACRO some \
    stuff

This should be an easy thing to add

@pdogr
Copy link
Contributor

pdogr commented Jan 25, 2022

Hi!
I've tried adding this feature in #538. I was not sure if we should preserve the exact structure (escaped newlines) in macro definition, though this would really depend on whether the assembly has a free-form syntax?

@jhand2
Copy link
Contributor Author

jhand2 commented Jan 26, 2022

Thanks! It's worth noting that since #504 was resolved, oreboot assembly no longer uses rpp to insert macros. Apologies for not updating this issue.

That says, rpp is still fun endeavor and I'll take a look at the PR.

@pdogr
Copy link
Contributor

pdogr commented Jan 27, 2022

Sorry! I should've asked before picking this up.

@jhand2
Copy link
Contributor Author

jhand2 commented Jan 27, 2022

No problem 😄 I might move rpp into it's own repo/crate at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Feature Request Good First Issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants