You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
I'm using the IconComponent() component to render icon in table headers. That was working fine in orchid 14.21.0.
Yesterday I tested orchid 14.22.0 and it's throwing an error now.
I'm not able to update Laravel to v11 because of some dependencies so I can't test orchid 14.23.0 yet. But I guess the issue will also apply in 14.23.0 when I check the files changes.
To Reproduce TD::make('foo', (new IconComponent('bs.file-earmark-medical', '', null, '1.3em', '1.3em'))->render()())
Orchid\Icons\IconComponent::__construct(): Argument #1 ($finder) must be of type Orchid\Icons\IconFinder, string given, called in /Users/...../app/Orchid/Layouts/Order/OrderViewOrderItemLayout.php on line 144
Server (please complete the following information):
Platfrom Version: 14.22.0
Laravel Version: 10.43.0
PHP Version: 8.3
Database: MySQL
Database Version: 8.3.0
The text was updated successfully, but these errors were encountered:
Hello! I'm sorry you've encountered this issue. It's because some components were reworked to avoid generating temporary compiled Blade files, which was impacting performance. Unfortunately, I didn't explicitly document this change and didn't anticipate its consequences.
Currently, icon rendering relies entirely on blade, so it's challenging to invoke it as you wish. Here are approximate steps:
Thank you, that did help alot.
To use it for the table heading I only had to add ->__toString() at the end to avoid the "must be string" error and it's working.
Still hope for the icon feature for tables #2732 ;)
Describe the bug
I'm using the IconComponent() component to render icon in table headers. That was working fine in orchid 14.21.0.
Yesterday I tested orchid 14.22.0 and it's throwing an error now.
I'm not able to update Laravel to v11 because of some dependencies so I can't test orchid 14.23.0 yet. But I guess the issue will also apply in 14.23.0 when I check the files changes.
To Reproduce
TD::make('foo', (new IconComponent('bs.file-earmark-medical', '', null, '1.3em', '1.3em'))->render()())
Orchid\Icons\IconComponent::__construct(): Argument #1 ($finder) must be of type Orchid\Icons\IconFinder, string given, called in /Users/...../app/Orchid/Layouts/Order/OrderViewOrderItemLayout.php on line 144
Server (please complete the following information):
The text was updated successfully, but these errors were encountered: