New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix with Picture filed bug #2258

Open

Kostyavas opened this issue Jun 3, 2022 · 0 comments · May be fixed by #2259

Assignees

Labels

Errors

Kostyavas commented Jun 3, 2022 •

edited by tabuna

Describe the bug
Matrix duplicates images for new fields

To Reproduce

Create Matrix with Picture field.

 Matrix::make('test')
    ->columns([
       'Picture' => 'picture',
       'Text' => 'text',
   ])
   ->fields([
       'picture' => Picture::make('picture')->maxFileSize(2)->targetId(),
       'text' => Input::make()->type('text'),
   ])

Add picture
Save to database
Refresh page
Try to add new row in matrix

Expected behavior
Clear new field without image

Screenshots
Screenshot of a bug:

This happens because the matrix doesn't clear data-picture-url in template

Kostyavas added the Errors label

Kostyavas assigned tabuna

Kostyavas linked a pull request

that will close this issue

fix matrix rows with picture field #2259

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment