Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make environment builds more robust w.r.t. .orchest being git ignored #1494

Open
fruttasecca opened this issue Jan 3, 2023 · 1 comment
Open
Labels
good first issue Good for newcomers improvement An improvement or enhancement to an existing feature.

Comments

@fruttasecca
Copy link
Member

fruttasecca commented Jan 3, 2023

Describe the problem this improvement solves
Orchest expects the .orchest/environments directory to be versioned (or, at least, to not be .gitignore'd). This is because an environment build will take a snapshot of the project, and said snapshot will exclude files and directories according to the .gitignore file. However, some users would like to not version any content of the .orchest directory.

Describe the solution you'd like
The build should work regardless of the .orchest directory being in the snapshot or not. Making the build read the environment properties and setup script prior to the snapshot should be feasible. Note: the PR fixing this should include some changes to docs/source/fundamentals/environments.md to remove the notion that .orchest/environments shouldn't be git ignored (i.e. revert 02c2fa4.

@fruttasecca fruttasecca added good first issue Good for newcomers improvement An improvement or enhancement to an existing feature. labels Jan 3, 2023
@hparashar27
Copy link

hey @fruttasecca can i start working on it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement An improvement or enhancement to an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants