Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Touch based devices]: Cannot connect steps with connections by drag&drop using the mouse's left button #1312

Open
mikrobe opened this issue Sep 27, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@mikrobe
Copy link

mikrobe commented Sep 27, 2022

Describe the bug
Nothing happens when you hover over a step shape's dot, you left-button click and drag toward another step.
Do the same using the right button and it works at a certain extent. In fact, in order to make the connection link to the target step, you need to drag the mouse inside the step and not only on the dot.
This only happens when I use Chrome or Firefox in Windows 11.
I launched Chrome from the WSL and it works properly.

Expected behavior
The connection line should appear

To Reproduce
Steps to reproduce the behavior:

  1. Add two steps in a pipeline
  2. Left Click on the dot of a step and drag to the other step
  3. See nothing happens
  4. Right Click on the dot of a step and drag to the other step
  5. The connection line appears
  6. If you release the button when over the dot, the shape context menu appears instead of connecting the line to the shape
  7. If you release the button when you are inside the shape, the line connects to the shape.

Environment

  • Microsoft Surface Pro
  • OS (e.g. macOS): Microsoft Windows 11
  • Browser (e.g. Chrome): Chrome Version 105.0.5195.127 (Official Build) (64-bit), Firefox 105.0.1 (64-bit
  • Orchest's version (in the settings page): v2022.09.6 (same problem with the previous version 2022.08.something)
@mikrobe mikrobe added the bug Something isn't working label Sep 27, 2022
@welcome
Copy link

welcome bot commented Sep 27, 2022

❤️ Thanks for opening your first issue! We really appreciate your input.
💬 If you need to connect more synchronously with members of the Orchest community, please feel free to chat with us on our Slack.

@ricklamers
Copy link
Member

Thanks for reporting @mikrobe

We’ll investigate, this obviously shouldn’t happen.

@ricklamers
Copy link
Member

I failed to reproduce this issue on Windows 11 from Chrome (106.0.5249.62) and Firefox (105.0.1). Since you're using a Microsoft Surface Pro the touch-enabled display might be causing some issues here. We'll need a bit of time to get one to investigate what's going wrong here.

Sorry for the inconvenience, but we'll get to a fix as soon as possible.

@mikrobe
Copy link
Author

mikrobe commented Oct 4, 2022

Thank you for taking this in consideration so quickly. I understand it could be a corner case. Let me know if you need more information.

@yannickperrenet yannickperrenet changed the title Cannot connect steps with connections by drag&drop using the mouse's left button [Touch based devices]: Cannot connect steps with connections by drag&drop using the mouse's left button Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants