Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit testing fails when define has been proxied/ abstracted, etc #519

Open
gillyspy opened this issue Jan 31, 2022 · 2 comments
Open

unit testing fails when define has been proxied/ abstracted, etc #519

gillyspy opened this issue Jan 31, 2022 · 2 comments
Labels
bug Something isn't working tracked Already in Backlog

Comments

@gillyspy
Copy link

Your environment

OS : macOS 12
Node.js version : 16.13.2
suitecloud-cli version : 1.3.1
Terminal/CMD tool : iTerm

Describe the bug

unit testing module does not support a customized define

To Reproduce

Steps to reproduce the behavior:

  1. create a module like this:
const x = define;
x([], ()=>{
}); 
  1. test with suitecloud

Actual Behavior

ReferenceError: define is not defined

Expected Behavior

that should work. While this is a contrived example it's based on something real. we have define conditionally wrapped in node because we were doing unit testing in the past (before suitecloud solution) came along and needed a way to test them

Additional context

how are you executing this if define does not exist?

@gillyspy gillyspy added the bug Something isn't working label Jan 31, 2022
@gillyspy
Copy link
Author

gillyspy commented Feb 3, 2022

i opened this issue for you guys. Can you try it? or how can i try it with your package?

@tourajvaziri tourajvaziri added the tracked Already in Backlog label Oct 7, 2022
@tourajvaziri
Copy link
Member

Hi @gillyspy ,
Thanks for reporting this. We will investigate this when we can and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tracked Already in Backlog
Projects
None yet
Development

No branches or pull requests

2 participants