Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle rate limits in slack connector methodsearch_history_messages #1977

Open
FabioRosado opened this issue Jan 8, 2023 · 0 comments
Open

Comments

@FabioRosado
Copy link
Member

While working with @rodrigo-albuquerque on #1961 I've noticed that the method search_history_messages is also not handling any ratelimit exceptions (or any SlackApiError exceptions), we should do two things:

  • remove the infinite look white True and use something like 'max_retries` set to 5 retries
  • Handle any exception raised by slack when we call conversations_history and decrease max_retries (this will cause the loop to break)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant