Add filters LESSTHAN & GREATERTHAN to FilterMatchTypeEnum (#6319) #6437
Conversation
quinarygio
force-pushed
the
FE-6319-cards-filter-gt-lt
branch
2 times, most recently
from
0164123
to
f28d265
Compare
| NOTCONTAINS, | ||
| BLANK, | ||
| NOTBLANK, | ||
| IN | ||
| IN, | ||
| LESSTHAN, | ||
| GREATERTHAN |
There was a problem hiding this comment.
I propose to set the order as alphabetical to ease reading
| NOTCONTAINS, | ||
| BLANK, | ||
| NOTBLANK, | ||
| IN | ||
| IN, | ||
| LESSTHAN, | ||
| GREATERTHAN | ||
| } |
There was a problem hiding this comment.
I propose to set the order as alphabetical to ease reading
| } catch (NumberFormatException | NoSuchFieldException | SecurityException e) { | ||
| // Ignore criteria on wrong columns | ||
| } |
There was a problem hiding this comment.
I suggest handling exceptions within each case of the getMatchingCriteria switch statement and adding a meaningful log.warn.
This would make it easier to identify and resolve potential problems.
There was a problem hiding this comment.
After discussion it was decided to keep it as it is, because the behaviour is similar to the current implementation: if a wrong column is specified in the condition than the condition is ignored.
quinarygio
force-pushed
the
FE-6319-cards-filter-gt-lt
branch
from
f28d265
to
3a96c45
Compare
Signed-off-by: Giovanni Ferrari <giovanni.ferrari@soft.it>
quinarygio
force-pushed
the
FE-6319-cards-filter-gt-lt
branch
from
3a96c45
to
3c6ccdb
Compare
|
Fix #6319