Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InstallPlan Finalizers to OLM #3154

Open
tmshort opened this issue Jan 11, 2024 · 0 comments
Open

Add InstallPlan Finalizers to OLM #3154

tmshort opened this issue Jan 11, 2024 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tmshort
Copy link
Contributor

tmshort commented Jan 11, 2024

Feature Request

Is your feature request related to a problem? Please describe.

See #3108 and corresponding discussion:
https://kubernetes.slack.com/archives/C0181L6JYQ2/p1704293361617039

With various performance improvements, the test case in #3108 started to fail more frequently, as the Subscription would re-create the CSV faster, subsequently blocking the CR/CRBs from being deleted, and thus causing the test to fail.

However, finalizers are not used (in general) for cleanup, and should be added.

Describe the solution you'd like
Add finalizers for appropriate deletion actions.

InstallPlan Finalizer
In another case, it is possible to put a Subscription into a non-functional state if an InstallPlan is deleted too quickly:

  1. Create Subscription with Manual Approval
  2. Delete the resulting InstallPlan as quickly as possible
  3. Wait for a new InstallPlan to be created

Often times step 3 will not occur, which results in the creation manual approval e2e test flaking.

Other finalizers may also be necessary, but we want to ensure these are resolved.

Copied from #3143

@tmshort tmshort added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 11, 2024
This was referenced Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant