You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With various performance improvements, the test case in #3108 started to fail more frequently, as the Subscription would re-create the CSV faster, subsequently blocking the CR/CRBs from being deleted, and thus causing the test to fail.
However, finalizers are not used (in general) for cleanup, and should be added.
Describe the solution you'd like
Add finalizers for appropriate deletion actions.
InstallPlan Finalizer
In another case, it is possible to put a Subscription into a non-functional state if an InstallPlan is deleted too quickly:
Create Subscription with Manual Approval
Delete the resulting InstallPlan as quickly as possible
Wait for a new InstallPlan to be created
Often times step 3 will not occur, which results in the creation manual approval e2e test flaking.
Other finalizers may also be necessary, but we want to ensure these are resolved.
Feature Request
Is your feature request related to a problem? Please describe.
See #3108 and corresponding discussion:
https://kubernetes.slack.com/archives/C0181L6JYQ2/p1704293361617039
With various performance improvements, the test case in #3108 started to fail more frequently, as the Subscription would re-create the CSV faster, subsequently blocking the CR/CRBs from being deleted, and thus causing the test to fail.
However, finalizers are not used (in general) for cleanup, and should be added.
Describe the solution you'd like
Add finalizers for appropriate deletion actions.
InstallPlan Finalizer
In another case, it is possible to put a Subscription into a non-functional state if an InstallPlan is deleted too quickly:
Often times step 3 will not occur, which results in the
creation manual approval
e2e test flaking.Other finalizers may also be necessary, but we want to ensure these are resolved.
Copied from #3143
The text was updated successfully, but these errors were encountered: