Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config var uniformity #1946

Open
qrkourier opened this issue Apr 16, 2024 · 0 comments
Open

config var uniformity #1946

qrkourier opened this issue Apr 16, 2024 · 0 comments

Comments

@qrkourier
Copy link
Member

The inconsistency between these names is stumbling block for learners:

  • ZITI_CTRL_ADVERTISED_ADDRESS
  • ZITI_CTRL_ADVERTISED_PORT
  • ZITI_ROUTER_ADVERTISED_ADDRESS
  • ZITI_ROUTER_PORT

A minimal solution would be to introduce ZITI_ROUTER_ADVERTISED_ADDRESS as a replacement for ZITI_ROUTER_PORT while continuing to allow ZITI_ROUTER_PORT to function as an alias for the new var.

My personal preference is less minimal and aims for slightly improved aesthetics by shortening the other three, which are still unambiguous now that we're prescribing a single address and port as a best practice (thanks, ALPN):

  • ZITI_CTRL_ADDRESS
  • ZITI_CTRL_PORT
  • ZITI_ROUTER_ADDRESS
  • ZITI_ROUTER_PORT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant