New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build steps that use ziti-runner cannot run node 20 #26
Comments
That's a pickle. If they pin those Actions to a version that uses NodeJS 16, they'll eventually stop working when GitHub decommissions it. That sounds like the only immediate workaround. I'll have to research how the NodeJS runtime installed. Actions' |
https://unofficial-builds.nodejs.org/download/release/v20.9.0/node-v20.9.0-linux-x64-glibc-217.tar.gz seems to work in a clean bionic container:
|
Will the Actions that declare a particular NodeJS runtime version use the version available inside the builder container image unconditionally, or only if the NodeJS version matches their declared version? If the Actions preferentially use the versions of NodeJS installed in the builder image, then we can supply a range of NodeJS versions there, and the Actions can choose, if there's a well-known filesystem path where they expect to find versions. I suppose it can't be the same filesystem path used by the GH runner because those are presumably being mounted as a bind volume on the runner container. I'm uncertain about how that works. |
The easiest solution would be to abandon bionic and build on focal. I'm willing to keep this open until one of the two triggers occur.
|
builds in ziti-tunnel-sdk-c and ziti-sdk-c recently started failing when running the
lukka/get-cmake
andlukka/run-cmake
actions:It turns out that the actions were recently updated to use node 20, since node 16 is being deprecated by GH). I think our options are to either find/create a build of node20 that runs on bionic, or inform downstream projects to pin
run-cmake
to "v10.6" andget-cmake
to "v3.27.7"The text was updated successfully, but these errors were encountered: