You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The build shows many issues about redefined CHECK macros such as:
In file included from external/xla/xla/status.h:19,
from external/xla/xla/pjrt/exceptions.h:28,
from external/xla/xla/pjrt/status_casters.h:19,
from external/xla/xla/python/pjit.cc:32:
external/com_google_absl/absl/log/check.h:57: warning: "CHECK" redefined
57 | #define CHECK(condition) ABSL_LOG_INTERNAL_CHECK_IMPL((condition), #condition)
|
In file included from external/tsl/tsl/platform/logging.h:26,
from external/xla/xla/pjrt/lru_cache.h:22,
from external/xla/xla/python/pjit.cc:31:
external/tsl/tsl/platform/default/logging.h:308: note: this is the location of the previous definition
308 | #define CHECK(condition) \
The reason is that both Abseil and TSL are used to get those macros. E.g.
3edc99b was an attempt to fix this by undefining the CHECK macros in TSL. However now it depends on the import order which set of macros is "active" and whether those warnings are shown.
A proper fix as mentioned in that commit is to NEVER introduce macros without some kind of prefix. Especially not macros with such generic names which are even known to be defined/used in other libraries used.
An intermediate fix is to commit at least in a single library to one set of macros. I.e. not use Abseil and TSL from XLA.
The text was updated successfully, but these errors were encountered:
The build shows many issues about redefined
CHECK
macros such as:The reason is that both Abseil and TSL are used to get those macros. E.g.
xla/xla/status.h
Line 19 in ab0ce49
xla/xla/pjrt/lru_cache.h
Line 22 in ab0ce49
3edc99b was an attempt to fix this by undefining the CHECK macros in TSL. However now it depends on the import order which set of macros is "active" and whether those warnings are shown.
A proper fix as mentioned in that commit is to NEVER introduce macros without some kind of prefix. Especially not macros with such generic names which are even known to be defined/used in other libraries used.
An intermediate fix is to commit at least in a single library to one set of macros. I.e. not use Abseil and TSL from XLA.
The text was updated successfully, but these errors were encountered: