Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CollectiveBroadcast should add use_global_device_ids to its hlo construction #10992

Open
chaserileyroberts opened this issue Mar 27, 2024 · 0 comments
Open

CollectiveBroadcast should add use_global_device_ids to its hlo construction #10992

chaserileyroberts opened this issue Mar 27, 2024 · 0 comments
Assignees
@frgossen

Comments

@chaserileyroberts
Copy link
Contributor

Currently, CB does not have use_global_device_ids. This prevents it from picking the right "cross partition / replication" strategy, and can cause crashes when using jax.lax.pbroadcast in edge-case setups.

This should be straightforward to add.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frgossen frgossen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frgossen @chaserileyroberts