[qa] Commit message check fails if there's a dot after the issue

[nemesifier]

Eg: Closes #344.: https://github.com/openwisp/openwisp-controller/runs/2529479318

[keshavgbpecdelhi]

Can I do this issue

[devkapilbansal]

Sure @keshavgbpecdelhi go ahead

[keshavgbpecdelhi]

@devkapilbansal can you tell were to do changes (which code required modification)

[devkapilbansal]

I think you need to fix this function

openwisp-utils/openwisp_utils/qa.py

Line 83 in 1f73cc3

def check_commit_message():

I tried looking at that issue and found that regex is returning #344. from long description which is then matched with #344 from short description and the tests failed because #344. is not same as #344

[keshavgbpecdelhi]

Do we have to add "." in the skip case?
skip_cases = [
# merges
r'^Merge pull request #[A-Za-z0-9.]* from',
r"^Merge branch '(.?)' into",
# releases
r'^[A-Za-z0-9.] release$',
r"^Bumped VERSION to (.?)$",
r"^Bump (.?) from (.?) to (.?)$",
]

[keshavgbpecdelhi]

It is written not to add "."

openwisp-utils/openwisp_utils/qa.py

Line 108 in 1f73cc3

'please do not add a final dot at the end of commit short description'

[devkapilbansal]

It is for short description only

[devkapilbansal]

@keshavgbpecdelhi did you tried going throigh the code once and undertand what's going there ? The best way to fix the error is to try reproduce it locally, see which part of code is responsible for that, writing a test case that will fail for sure unless the error is fixed and then solving the error.

[nemesifier]

@keshavgbpecdelhi first step is to write a failing test to replicate the issue, see https://github.com/openwisp/openwisp-utils/blob/master/tests/test_project/tests/test_qa.py#L79-L135.