[bug] FreeRADIUS PostAuthView returns 500 error #467
Labels
bug
Something isn't working
good-first-issue
Good for newcomers
Hacktoberfest
Easy issues for attracting Hacktoberfest participants.
Projects
Comments
pandafy
moved this from To do (general)
to To do (Python & Django)
in OpenWISP Contributor's Board
nemesifier
moved this from To do (Python & Django)
to To do (ansible/docker)
in OpenWISP Contributor's Board
nemesifier
moved this from To do (ansible/docker)
to To do (Python & Django)
in OpenWISP Contributor's Board
|
@pandafy I want to work on this issue, can you assign this issue to me? |
|
@ujjwalkirti you can start working on this issue. You don't need to wait for someone to assign this issue to you, just an intent message is enough. 😄 I would recommend you to start by writing a failing test case before updating the serializer. I would also recommend you to join the OpenWISP development chat. |
pandafy
added
good-first-issue
|
can i start working on this? |
|
Yes @nick2432, go ahead! Don't forget to read my previous comments. |
Shiva953
added a commit
to Shiva953/openwisp-radius
that referenced
this issue
Feb 18, 2024
Set the max_length attribute to be equal to 50 on the called_station_id field, so that it doesn't give a 500 error(400 error instead) every time it exceeds 50. Fixes openwisp#467
Shiva953
added a commit
to Shiva953/openwisp-radius
that referenced
this issue
Feb 22, 2024
The QA check was failing earlier because the latest commit wasn't following the conventional commit guidelines, this commit fixes it. Ran both the openwisp-qa-format and openwisp-qa-check commands. Fixes openwisp#467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The FreeRADIUS PostAuthView (
/api/v1/freeradius/postauth/) returns HTTP 500 error if the length ofcalled_station_idfield exceeds 50 characters.A possible fix could be to update the PostAuthSerializer and set
max_lengthattribute on thecalled_station_idfield. This way, the view would return HTTP 400 with the error reason.The text was updated successfully, but these errors were encountered: