Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] IP Validation does not consider heirachical subnets #116

Open
morganrallen opened this issue Sep 22, 2021 · 0 comments
Open

[bug] IP Validation does not consider heirachical subnets #116

morganrallen opened this issue Sep 22, 2021 · 0 comments
Labels
bug Something isn't working Hacktoberfest Easy issues for attracting Hacktoberfest participants.
Projects
OpenWISP Contributor's Board OpenWISP Priorities for next releases

Comments

@morganrallen
Copy link

Presently the clean method of the AbstractIpAddress class only validates against IPs existing in it's own subnet.
As per discussion in #114 an IP existing in a parent or child subnet should be considered used.

If this is valid I've already started on a patch, working up the tree is straight forward.
@nemesifier nemesifier added the bug Something isn't working label Sep 23, 2021
@nemesifier nemesifier changed the title IP Validation does not consider heirachical subnets [bug] IP Validation does not consider heirachical subnets Sep 23, 2021
@nemesifier nemesifier added this to Backlog in OpenWISP Priorities for next releases via automation Sep 23, 2021
@nemesifier nemesifier added this to To do (general) in OpenWISP Contributor's Board via automation Sep 23, 2021
@nemesifier nemesifier added the Hacktoberfest Easy issues for attracting Hacktoberfest participants. label Sep 23, 2021
@pandafy pandafy moved this from To do (general) to To do (Python & Django) in OpenWISP Contributor's Board Sep 30, 2021
@pandafy pandafy added this to the Release 0.3.0 milestone Jan 26, 2022
@pandafy pandafy moved this from Backlog to To do in OpenWISP Priorities for next releases Jan 31, 2022
@nemesifier nemesifier moved this from To do to In progress in OpenWISP Priorities for next releases Apr 20, 2022
@nemesifier nemesifier moved this from In progress to To do in OpenWISP Priorities for next releases Apr 20, 2022
@nemesifier nemesifier removed this from the Release 1.0.0 milestone Apr 28, 2022
@nemesifier nemesifier moved this from To do to Backlog in OpenWISP Priorities for next releases May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Hacktoberfest Easy issues for attracting Hacktoberfest participants.
Projects
OpenWISP Contributor's Board
  
To do (Python & Django)
OpenWISP Priorities for next releases
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@morganrallen @nemesifier @pandafy