Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issue on the fetching of activity history #682

Open
1 of 2 tasks
adrienjoly opened this issue Aug 26, 2023 · 1 comment
Open
1 of 2 tasks

Performance issue on the fetching of activity history #682

adrienjoly opened this issue Aug 26, 2023 · 1 comment
Assignees
@adrienjoly
Labels
enhancement

Comments

@adrienjoly
Copy link
Member

adrienjoly commented Aug 26, 2023 •
edited

Follow up of #681.

Problem: fetching and rendering Israel's profile took 4 seconds, including 1.6 seconds just to fetch his activity history!

image

TODO before closing

  • disable the fetching of followed users' activity, from the feed/home page
  • delete up unused/useless code, including calls to console.time() and console.timeEnd()
@adrienjoly adrienjoly self-assigned this Aug 26, 2023
adrienjoly added a commit that referenced this issue Sep 2, 2023
@adrienjoly
fix(perf): disable history on home page
52536d3 
temporary workaround to reduce stress on mongodb, until we find a solution to solve #681 and #682.
root cause may be caused/related to #630 and/or #634.
adrienjoly pushed a commit that referenced this issue Sep 2, 2023
@semantic-release-bot
chore(release): 1.55.61 [skip ci]
fdc8628 
## [1.55.61](v1.55.60...v1.55.61) (2023-09-02)

### Bug Fixes

* linter issues caused by previous commit ([17998a1](17998a1))
* **perf:** disable history on home page ([52536d3](52536d3)), closes [#681](#681) [#682](#682) [#630](#630) [#634](#634)
@adrienjoly
Copy link
Member Author

adrienjoly commented Sep 3, 2023 •
edited

the "activity" sidebar section seems to put high stress on our mongodb instance.

image

...which makes sense because it starts non-optimized and heavy db queries against all the users followed by the logged user.

=> after several outages in production, I decided to turn that feature off by commenting out the corresponding code, in 52536d3 and 17998a1

=> if there are no outages in the coming week, we should probably just get rid of this feature, for good, by deleting the commented code.

@adrienjoly adrienjoly mentioned this issue Sep 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrienjoly adrienjoly

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adrienjoly