fix(security): XSS with user name on profile (#506)

cf https://huntr.dev/bounties/c9061d03-f0e5-4eff-aa0b-7364b48de647/
openwhyd · Dec 11, 2021 · 14e0d40 · 14e0d40
1 parent 74b9607
commit 14e0d40
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/app/templates/mainTemplate.js b/app/templates/mainTemplate.js
@@ -301,7 +301,9 @@ exports.renderHeader = function (user, content, params) {
             '     <div class="image" style="background-image:url(' +
               (user.img || '/img/u/' + user.id) +
               ');"></div>',
-            '			<strong class="username">' + user.name + '</strong>',
+            '			<strong class="username">' +
+              uiSnippets.htmlEntities(user.name) +
+              '</strong>',
             //	'      <img src="/img/u/'+user.id+'" />', // /images/icon-userconfig-menu.png
             '    </a>',
             '    <div class="puce">',