fix: process problem report message #1859
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>
TimoGlastra
requested changes
May 8, 2024
Comment on lines
140
to
145
|
|
||
| const connection = messageContext.assertReadyConnection() | ||
|
|
||
| agentContext.config.logger.debug(`Processing problem report with message id ${credentialProblemReportMessage.id}`) | ||
|
|
||
| const credentialRecord = await this.getByProperties(agentContext, { | ||
| threadId: credentialProblemReportMessage.threadId, | ||
| connectionId: connection.id, | ||
| }) |
There was a problem hiding this comment.
This is dangerous as it allows anyone to send a response to the credential exchange by knowing the thread id. For this reason we don't support problem reports currently for connectionsless exchanges.
If we want to support this, we need to handle it the same as is done in the processRequest message. Which consists of:
- query the record without connection id
- then if the record has a connection id:
- check if it matches the connection id from the exchange
- if the record does not have a connection id:
- check that the problem report is authorized based on the out of band exchange (the parentThreadId also need to match)
- if the incoming message has a connection associated, update the connectionId in the exchange record
This is already implemented like this for processRequest, and I think you can copy most of the logic
Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>
Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>
|
Hmm it seems there's a small issue with the logic (not from your code. I'll push some changes to this PR tomorrow to fix that as well) |
Signed-off-by: Timo Glastra <timo@animo.id>
|
Pushed some changes @sairanjit |
Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>
|
@TimoGlastra I removed this check const connection = messageContext.assertReadyConnection()As it was failing for connection less flows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1858