Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HMAC CPU formats use SIMD and OpenMP fully #5421

Open
solardiz opened this issue Jan 8, 2024 · 0 comments
Open

Make HMAC CPU formats use SIMD and OpenMP fully #5421

solardiz opened this issue Jan 8, 2024 · 0 comments

Comments

@solardiz
Copy link
Member

solardiz commented Jan 8, 2024

I was surprised to find that our HMAC CPU formats use scalar hashing code in set_key even when building with SIMD. This also puts such code out of OpenMP parallel sections. We should probably replace this with equivalent functionality inside crypt_all, reached when new_keys is set (we already have some code only reached on new_keys in there, but we could move more code to there).

No wonder there's such a big difference between Many vs. Only one salt speeds for these formats. These changes should improve the Only one salt speed (as well as actual cracking with few different salts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant