Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the RAdmin format to thin around dynamic_1010, or optimize #5419

Open
solardiz opened this issue Jan 7, 2024 · 0 comments
Open

Convert the RAdmin format to thin around dynamic_1010, or optimize #5419

solardiz opened this issue Jan 7, 2024 · 0 comments

Comments

@solardiz
Copy link
Member

solardiz commented Jan 7, 2024

The RAdmin format uses scalar MD5 code. Equivalent functionality is implemented in dynamic_1010 with SIMD. We could convert it similarly to what we already did with a few other formats:

$ grep 'thin format' *.c
NS_fmt_plug.c: * Changed to thin format dynamic_2004, Dec 2014, JimF
asaMD5_fmt_plug.c: * Converted to thin format, into $dynamic_20$ format.
mediawiki_fmt_plug.c: * This thin format will change the above line into this, for hooking
pixMD5_fmt_plug.c: * Converted to thin format, into $dynamic_19$ format.

Alternatively, optimize it to use SIMD directly, and perhaps to reverse MD5 steps for the second block (something dynamic doesn't do - but maybe it could be enhanced, too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant