Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider salt progress for ETA #5378

Open
solardiz opened this issue Nov 25, 2023 · 0 comments
Open

Consider salt progress for ETA #5378

solardiz opened this issue Nov 25, 2023 · 0 comments
Labels
enhancement RFC / discussion Help or comments wanted

Comments

@solardiz
Copy link
Member

As I suggested in https://www.openwall.com/lists/john-users/2023/11/15/2

We'd need the calculation to consider progress at processing more salts within the current batch of password candidates. Maybe instead of the actual number of candidate passwords processed, we could use a virtual number scaled by the ratio of salts processed so far. In other words, in p/s and ETA instead of the actual but lagging p, we could use p + kpc*saltn/salts. As a special case, on interrupt/restore we'd need to infer the number of previously processed salts. Another special case is "single crack" mode, where we should omit this logic.

Alternatively, as magnum suggested, we should at least mute ETA until the first block of candidates has been processed or if it matches the current time.

@solardiz solardiz added enhancement RFC / discussion Help or comments wanted labels Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement RFC / discussion Help or comments wanted
Projects
None yet
Development

No branches or pull requests

1 participant