Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTX v2 visual prompting tasks cannot load datumaro datasets #3227

Closed
goodsong81 opened this issue Mar 28, 2024 · 4 comments
Closed

OTX v2 visual prompting tasks cannot load datumaro datasets #3227

goodsong81 opened this issue Mar 28, 2024 · 4 comments
Assignees
Labels
FEATURE New feature & functionality
Milestone

Comments

@goodsong81
Copy link
Contributor

Describe the bug

                                                                                          ver.2.0.0                                                                                         Traceback (most recent call last):
  File "/home/songkich/miniconda3/envs/otx-v2/bin/otx", line 8, in <module>                                                                                                                     sys.exit(main())
             ^^^^^^
  File "/mnt/sdb/workarea/otx/src/otx/cli/__init__.py", line 17, in main
    OTXCLI()                                                                                                                                                                                  File "/mnt/sdb/workarea/otx/src/otx/cli/cli.py", line 56, in __init__
    self.run()
  File "/mnt/sdb/workarea/otx/src/otx/cli/cli.py", line 570, in run                                                                                                                             self.instantiate_classes()
  File "/mnt/sdb/workarea/otx/src/otx/cli/cli.py", line 349, in instantiate_classes                                                                                                             self.config_init = self.parser.instantiate_classes(self.config)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/songkich/miniconda3/envs/otx-v2/lib/python3.11/site-packages/jsonargparse/_deprecated.py", line 140, in patched_instantiate_classes
    cfg = self._unpatched_instantiate_classes(cfg, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/songkich/miniconda3/envs/otx-v2/lib/python3.11/site-packages/jsonargparse/_core.py", line 1182, in instantiate_classes
    cfg[subcommand] = subparser.instantiate_classes(cfg[subcommand], instantiate_groups=instantiate_groups)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/songkich/miniconda3/envs/otx-v2/lib/python3.11/site-packages/jsonargparse/_deprecated.py", line 140, in patched_instantiate_classes
    cfg = self._unpatched_instantiate_classes(cfg, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/songkich/miniconda3/envs/otx-v2/lib/python3.11/site-packages/jsonargparse/_core.py", line 1176, in instantiate_classes
    component.instantiate_class(component, cfg)
  File "/home/songkich/miniconda3/envs/otx-v2/lib/python3.11/site-packages/jsonargparse/_signatures.py", line 577, in group_instantiate_class
    parent[key] = instantiator_fn(group.group_class, **value)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/songkich/miniconda3/envs/otx-v2/lib/python3.11/site-packages/jsonargparse/_common.py", line 109, in default_class_instantiator
    return class_type(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/mnt/sdb/workarea/otx/src/otx/core/data/module.py", line 59, in __init__
    dataset = DmDataset.import_from(self.config.data_root, format=self.config.data_format)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/songkich/miniconda3/envs/otx-v2/lib/python3.11/site-packages/datumaro/components/dataset.py", line 816, in import_from
    importer(path, stream=cls._stream, **kwargs)
  File "/home/songkich/miniconda3/envs/otx-v2/lib/python3.11/site-packages/datumaro/plugins/data_formats/coco/importer.py", line 74, in __call__
    raise DatasetNotFoundError(path, self.NAME)
datumaro.components.errors.DatasetNotFoundError: Failed to find dataset 'coco_instances' at '/mnt/sdc/val-data/v2/zero_shot_visual_prompting/coco_car_person_medium_datumaro'

Steps to Reproduce

On the latest releases/2.0.0 branch (b55d82c)

otx train --config src/otx/recipe/zero_shot_visual_prompting/sam_tiny_vit.yaml --data_root /mnt/sdc/val-data/v2/zero_shot_visual_prompting/coco_car_person_medium_datumaro --work_dir /tmp/zvp

Same goes for visual_prompting task models.

Environment:

  • OS:
  • Framework version:
  • Python version:
  • OpenVINO version:
  • CUDA/cuDNN version:
  • GPU model and memory:
@goodsong81 goodsong81 added this to the 2.0.0 milestone Mar 28, 2024
@sungchul2
Copy link
Contributor

Could you add --data.config.data_format=datumaro in cli?

@goodsong81
Copy link
Contributor Author

Could you add --data.config.data_format=datumaro in cli?

I've removed that part after auto-config implemented. Feel free to assign this issue to @harimkang

@harimkang
Copy link
Contributor

For now, let's revise the milestone for this to 2.1.0.

@harimkang harimkang modified the milestones: 2.0.0, 2.1.0 Mar 29, 2024
@chuneuny-emily chuneuny-emily added the FEATURE New feature & functionality label Apr 5, 2024
@harimkang
Copy link
Contributor

@goodsong81 i create PR for this : #3579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature & functionality
Projects
None yet
Development

No branches or pull requests

4 participants