Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures on unittests for otx.core.ov modules #2675

Closed
yunchu opened this issue Nov 29, 2023 · 8 comments
Closed

Failures on unittests for otx.core.ov modules #2675

yunchu opened this issue Nov 29, 2023 · 8 comments
Assignees

Comments

@yunchu
Copy link
Contributor

yunchu commented Nov 29, 2023

Describe the bug

After upgrading openvino version to 2023.1, downloaded omz models were compressed with option of mo "--compress_to_fp16 true" as default. this leads some unittests failure.
ref. openvino 2023.1 release note
image

Steps to Reproduce

  1. delete cached omz model file if it exists
$ rm -rf ~/.cache/otx/omz
  1. run unittests
$ tox -vvv -e unittest-all-py310-pt1 -- tests/unit/core/ov/graph/test_ov_graph_utils.py::test_handle_reshape
  1. TypeError will be occurred
========================================================================== short test summary info ==========================================================================
FAILED tests/unit/core/ov/graph/test_ov_graph_utils.py::test_handle_reshape - TypeError: can't convert np.ndarray of type numpy.uint16. The only supported types are: float64, float32, float16, complex64, complex128, int64, int32, int16, int8, uin...

Environment:

  • OS: Ubuntu 20.04
  • Framework version: Pytorch
  • Python version: 3.9
  • OpenVINO version: 2023.1
  • CUDA/cuDNN version: 11.7
  • GPU model and memory:
@yunchu
Copy link
Contributor Author

yunchu commented Nov 29, 2023

some of the CI runners have uncompressed model files in their cache directory so that would not be resulted as failure. but on the un-cached machine, TC failures will be occurred due to the compressed model is not suitable to some current unittests design.

@vinnamkim
Copy link
Contributor

I think that this test would be better to be moved to "intergation" test. This is because this test can be affected by the external components: 1) OpenVINO Model Optimizer and 2) Downloaded IR file. In addition, the integration test should not be stateful (affected by the local caching directory like this).

@sovrasov
Copy link
Contributor

sovrasov commented Nov 29, 2023

@yunchu thanks for the investigation! Could you delete the cache where applicable?

@vinnamkim indeed, current design doesn't correspond to the unit tests conception. Are there any plans to add this OV graph parsing functionality to OTX 2.0? If yes, we could think about refactoring in advance

@yunchu
Copy link
Contributor Author

yunchu commented Nov 29, 2023

@yunchu thanks for the investigation! Could you delete the cache where applicable?

@vinnamkim indeed, current design doesn't correspond to the unit tests conception. Are there any plans to add this OV graph parsing functionality to OTX 2.0? If yes, we could think about refactoring in advance

@sovrasov actually deleting cache would not resolve this issue. we have bumped up the version of openvino to 2023.1 so the downloaded and converted (via mo) model will be compressed with fp16 by the default option to the mo. it leads current unittest failures.

@yunchu
Copy link
Contributor Author

yunchu commented Nov 30, 2023

FYI, i've manually pushed uncompressed version of models to the CI runner's cache now. so, i think related TCs would be passed from now on.

@vinnamkim
Copy link
Contributor

@vinnamkim indeed, current design doesn't correspond to the unit tests conception. Are there any plans to add this OV graph parsing functionality to OTX 2.0? If yes, we could think about refactoring in advance

Yea, I'm planning to move all test functions which require external components explicitly like this to the integration test.

@sovrasov
Copy link
Contributor

@yunchu thanks for the investigation! Could you delete the cache where applicable?
@vinnamkim indeed, current design doesn't correspond to the unit tests conception. Are there any plans to add this OV graph parsing functionality to OTX 2.0? If yes, we could think about refactoring in advance

@sovrasov actually deleting cache would not resolve this issue. we have bumped up the version of openvino to 2023.1 so the downloaded and converted (via mo) model will be compressed with fp16 by the default option to the mo. it leads current unittest failures.

I asked this in the context of merging #2676
But keeping this cache is also an option, although it's implicit and should be maintained over time.

@sovrasov
Copy link
Contributor

Closed, since it's related to past 1.6 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants