Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

varlens-allele-support doesn't acceptable positional BAM argument #20

Open
iskandr opened this issue Apr 14, 2016 · 2 comments
Open

varlens-allele-support doesn't acceptable positional BAM argument #20

iskandr opened this issue Apr 14, 2016 · 2 comments

Comments

@iskandr
Copy link
Contributor

iskandr commented Apr 14, 2016

I currently have to use the named parameter --reads since varlens-allele-support doesn't interpret its first argument as a BAM.

@timodonnell
Copy link
Collaborator

Agree it's confusing. varlens-reads takes bams as positional arguments and variants as --variants whereas varlens-variants takes VCFs positionally (and reads with --reads), i.e. the convention is the primary kind of input to each tool is positional and the others are named options. However, it's kind of a tossup whether variants or reads are the "primary" input the varlens-allele-support, since typically it would be called with both, so I went with just having them both be named arguments.

Given that logic, think it would be clearer if allele support took the reads as positional? It's true that the reads are always required whereas the variants are optional (you could specify --locus instead of giving a VCF)

@iskandr
Copy link
Contributor Author

iskandr commented Apr 14, 2016

I would err on the side of consistency, even if it's a little awkward for one of the commands. Alternatively, I'd be happy with just always specifying --reads; the current mixed state is most confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants