Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpanOptions::getParent #48

Open
jcchavezs opened this issue Feb 9, 2018 · 1 comment
Open

Add SpanOptions::getParent #48

jcchavezs opened this issue Feb 9, 2018 · 1 comment

Comments

@jcchavezs
Copy link
Collaborator

Background

Most of the tracer implementations only support child_of reference type.

Problem

When implementing the startSpan method we need to iterate over all references in order to find the child_of reference.

Proposal

Having a SpanOptions::getParent encapsulating this method would be very useful.

Ping @tedsuo @felixfbecker @beberlei @lvht @yurishkuro

@yurishkuro
Copy link
Member

can it be a private helper method instead? Making it part of SpanOptions extends the API surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants