New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluent interface for Span #110

Open

memboc opened this issue Aug 19, 2020 · 0 comments

memboc commented Aug 19, 2020

Proposal

Would be great to make fluent interface for Span. It's very popular practice

now:

        $scope->getSpan()->setTag(Tags::ERROR, true);
        $scope->getSpan()->setTag(Tags::STATUS_CODE, $httpCode);
        $scope->getSpan()->log(['message' => $response]);

fluent interface:

        $scope->getSpan()
            ->setTag(Tags::ERROR, true)
            ->setTag(Tags::STATUS_CODE, $httpCode)
            ->log(['message' => $response]);

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment