Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client is closed when changing GOD outfit (GameMaster) 13.xx #2582

Open
3 of 5 tasks
odisk777 opened this issue Apr 28, 2024 · 5 comments
Open
3 of 5 tasks

client is closed when changing GOD outfit (GameMaster) 13.xx #2582

odisk777 opened this issue Apr 28, 2024 · 5 comments
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@odisk777
Copy link

odisk777 commented Apr 28, 2024

Priority

Medium

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

it is presenting a new bug when you try to change the outfit of the GOD In the client 13.xx the client closes automatically I was testing in oldprotocol and it doesn't close anymore when you try to put on some new outfits, the outfits of community manager, GameMaster, GOD no longer appear.

godbug

This function has been working normally for 2 months. I don't know at what point it got damaged.

"I have the latest version of canary".

What OS are you seeing the problem on?

Linux, Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@odisk777 odisk777 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Apr 28, 2024
@github-actions github-actions bot added Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing labels Apr 28, 2024
jprzimba added a commit to jprzimba/crystalserver that referenced this issue Apr 28, 2024
Discord: #yirosh
opentibiabr/canary#2582

* Dont show mounts if using Support outfits
@elsongabriel
Copy link
Contributor

This happens because the assembly box is always checked when opening an outfit customization window, but I'm already producing new bytes for the 13.34 client and this will be corrected, if anyone is as interested as I am, I could also get started If we update the bytes for the login in 13.34, we will not have this problem in the 13.34 client.

do you have this solution in canary src or in client? if it is in source, please create an pr or comment what you do.
tks.

but we have a pr with a temporary fix #2526

@Aerwix
Copy link
Contributor

Aerwix commented May 1, 2024

Related to: #2540

@Mirkaanks
Copy link
Contributor

This happens because the assembly box is always checked when opening an outfit customization window, but I'm already producing new bytes for the 13.34 client and this will be corrected, if anyone is as interested as I am, I could also get started If we update the bytes for the login in 13.34, we will not have this problem in the 13.34 client.

Indeed, this box is not automatically checked in the original game behavior.
~
It appears that the issue only occurs with the gamemaster outfit.
Customer support and Community Manager outfits do not trigger the debug.

@Aerwix
Copy link
Contributor

Aerwix commented May 1, 2024

Customer support and Community Manager outfits do not trigger the debug. <- Confirmed ✔️

@odisk777
Copy link
Author

odisk777 commented May 3, 2024

I think I gave a solution or at least I do not know if it is a 100% ideal solution, but before making it GOD you must put a vocation and then you put GOD and there will no longer close the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

4 participants