[Dbus] Set and GetAll methods throwing Error io.openthread.Error.NotFound: io.openthread.Error.NotFound error

[gadekula1]

Dbus set and GetAll methods throwing error.

Details:

DBUS_PROPERTY_SET_METHOD "Set"
DBUS_PROPERTY_GET_ALL_METHOD "GetAll"

Introspect for GetAll:

dbus-send command :
dbus-send --system --print-reply --dest=io.openthread.BorderRouter.wpan0 /io/openthread/BorderRouter/wpan0 org.free
desktop.DBus.Properties.GetAll string:"io.openthread.BorderRouter"
Error io.openthread.Error.NotFound: io.openthread.Error.NotFound

dbus-send --system --print-reply --dest=io.openthread.BorderRouter.wpan0 /io/openthread/BorderRouter/wpan0 org.free
desktop.DBus.Properties.GetAll string:io.openthread.BorderRouter
Error io.openthread.Error.NotFound: io.openthread.Error.NotFound

Introspect for set method:

dbus-send command

dbus-send --system --print-reply --dest=io.openthread.BorderRouter.wpan0 /io/openthread/BorderRouter/wpan0 org.free
desktop.DBus.Properties.Set string:io.openthread.BorderRouter string:RadioRegion variant:string:"1234"
Error io.openthread.Error.InvalidArgs: io.openthread.Error.InvalidArgs

dbus-send --system --print-reply --dest=io.openthread.BorderRouter.wpan0 /io/openthread/BorderRouter/wpan0 org.free
desktop.DBus.Properties.Set string:io.openthread.BorderRouter string:"RadioRegion" variant:string:"1234"
Error io.openthread.Error.InvalidArgs: io.openthread.Error.InvalidArgs

[superwhd]

I think your Set method failed because you didn't pass in a valid region code. Below command works for me.

dbus-send --system --print-reply --dest=io.openthread.BorderRouter.wpan0 /io/openthread/BorderRouter/wpan0 org.freedesktop.DBus.Properties.Set string:"io.openthread.BorderRouter" string:"RadioRegion" variant:string:"US"

[superwhd]

For the GetAll method, it failed due to an error when getting one of the unimplemented properties. When a feature is disabled at build time, its 'GetPropertyHandler' is still registered but it throws an OT_NOT_IMPLEMENTED error which results in the failure of GetAll.

@morningboata Shall we let GetAll tolerate OT_NOT_IMPLEMENTED error? See

ot-br-posix/src/dbus/server/dbus_object.cpp

Line 207 in 29cea6a

SuccessOrExit(error = p.second(dictEntryIter));

[morningboata]

It seems that once the compile time flag is defined, the runtime behavior is well-defined, so that we can fix the property's compile time registration issue instead of tolerate runtime OT_NOT_IMPLEMENTED error? That is:

1. print detail property name (p.first) and 'not implemented' error around

SuccessOrExit(error = p.second(dictEntryIter));

2. fix the error by stopping the property's registration if it is not available, similar to https://github.com/openthread/ot-br-posix/blob/main/src/dbus/server/dbus_thread_object.cpp#L209C3-L209C3

How do you think?

[superwhd]

Either one seems good to be. The first approach seems simpler to implement because it's feature-agnostic.