Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all styles lost upon upgrade to FF 68 #747

Closed
atomGit opened this issue Jul 14, 2019 · 17 comments
Closed

all styles lost upon upgrade to FF 68 #747

atomGit opened this issue Jul 14, 2019 · 17 comments

Comments

@atomGit
Copy link

atomGit commented Jul 14, 2019

FF 68
Manjaro/Arch
Stylus 1.5.3

all styles were lost after upgrade from FF v67.* to v68 - i suspect the data is still there, just that FF isn't loading/seeing it (same thing happened with another extension)

@eight04
Copy link
Collaborator

eight04 commented Jul 14, 2019

Check if this is the same problem: greasemonkey/greasemonkey#3045

@atomGit
Copy link
Author

atomGit commented Jul 14, 2019

BINGO

i'll let you close the issue since i don't know if you want to address the problem with an update

and thanks, i never would've guessed FPI would have caused this

@b16r05
Copy link

b16r05 commented Jul 18, 2019

Same thing happened to me. I do not have GM installed; instead I have FPI installed, but disabled: https://github.com/mozfreddyb/webext-firstpartyisolation

Can't read any addon data... not sure WTF happened!

FF has an automatic setting where bookmarks are saved everyday in JSON format. Why can't stylus do the same? 5 or 10 days worth of daily backup files in an easy to access location will make life so much easier for users, especially ones like me with about a 100 stylus installed for websites.

@0ki
Copy link

0ki commented Jul 18, 2019

Here's is a step-by-step solution to fix this. Probably doable by an extension update.

  1. privacy.firstparty.isolate=false
  2. shut down firefox
  3. rm -r ~/.mozilla/firefox/xxxxxxxxx.default/storage/default/moz-extension+++yyyyyyyy^firstPartyDomain=yyyyyyyy (the one for stylus!)
  4. start firefox
  5. export stylus styles to file
  6. privacy.firstparty.isolate=true
  7. restart firefox
  8. import stylus styles from file

PROFIT!

@0ki
Copy link

0ki commented Jul 18, 2019

You might also wanna try to move all the contents of folder ~/.mozilla/firefox/xxxxxxxxx.default/storage/default/moz-extension+++yyyyyyyy into ~/.mozilla/firefox/xxxxxxxxx.default/storage/default/moz-extension+++yyyyyyyy^firstPartyDomain=yyyyyyyy overwriting it.

That may also work.

@b16r05
Copy link

b16r05 commented Jul 18, 2019

So, for my case, what do I do? Some of them look like this:

moz-extension+++337a4497-5627-4a68-8543-06183122b0ae
moz-extension+++337a4497-5627-4a68-8543-06183122b0ae^userContextId=4294967295

So, does this mean anything with userContextId in folder name is created by and for FPI and must be removed?

EDIT: I never had FPI enabled before or after update to FF 68.

@narcolepticinsomniac
Copy link
Member

narcolepticinsomniac commented Jul 18, 2019

I never had FPI enabled before or after update to FF 68

All the extension does is automatically set the config on installation and toggle it on and off. You can check if it's enabled: about:config?filter=privacy.firstparty.isolate. Note the warning "This might void your warranty! Changing these advanced settings can be harmful to the stability, security, and performance of this application. You should only continue if you are sure of what you are doing."

bookmarks are saved everyday... 100 stylus

The difference in the amount of data is like comparing a receipt to a dictionary. If you're referring to sync, its size limitation is 100 KB. You likely have single styles larger than that. I'm not familiar with FF, so if you're talking about some other feature, it'd be one built into the browser, specifically for bookmarks, not an API available to extensions.

You can manually export your backup with a single click, or sync to Dropbox at any time. FF is notorious for allowing various privacy settings to affect extension storage which is supposed to be off limits, so if you mess with these types of settings, be proactive and back up your DB often.

@0ki
Copy link

0ki commented Jul 18, 2019

None of my styles are larger than 3kB and my 6 styles take up 7kB in total. Not that I'd use sync anyway. :)

@b16r05
Copy link

b16r05 commented Jul 18, 2019

about:config?filter=privacy.firstparty.isolate was always set to FALSE. I actually had it disabled from about:addons, even before the update. So, I am not sure why I am affected!

Since then, I have enabled it, disabled it, done what you said above, changed about:config?privacy.firstparty.isolate.restrict_opener_access to FALSE, removed FPI... nothing!

At one point, lots of firstPartyDomain folders, duplicate ones with (2) (3), were created... on renaming them to .back and even deleting them, nothing!

The GreaseMonkey issue, although similar, does not apply nor worked for me, because besides the 3 firstPartyDomain folders that showed up later on, there were never there to begin with.

I am now too frustrated and need to give up. I have another addon whose data is lost as well. I have clearly no idea WTF FPI is doing... It is clearly a pain in the ass for me.

100 was an exaggerated number... what I meant was that I have one hundred styles installed. Actually on last count, I had about 86 styles installed... I keep finding new better ones and deleting old ones, sometimes, use two or three concurrently!

Thank you and everyone...

@narcolepticinsomniac
Copy link
Member

None of my styles are larger than 3kB and my 6 styles take up 7kB in total.

That's not typical though. Point is, it wouldn't work for the vast majority of users. Most around here use Github Dark, and that thing is an ungodly 600 KB+. I've been at this for years, so my backup is ~ 3.3 MB.

@b16r05
Copy link

b16r05 commented Jul 18, 2019

And, I am back : )

FPI is uninstalled and 3 firstPartyDomain have been deleted (although I have a backed profile)

So, now for stylus:

Webextension URL: moz-extension://337a4497-5627-4a68-8543-06183122b0ae/manage.html

Two corresponding folders:

moz-extension+++337a4497-5627-4a68-8543-06183122b0ae
moz-extension+++337a4497-5627-4a68-8543-06183122b0ae^userContextId=4294967295

There are two 3 firstPartyDomain folders in the backed profile

moz-extension+++337a4497-5627-4a68-8543-06183122b0ae^firstPartyDomain=337a4497-5627-4a68-8543-06183122b0ae
moz-extension+++337a4497-5627-4a68-8543-06183122b0ae^firstPartyDomain=337a4497-5627-4a68-8543-06183122b0ae (2)
moz-extension+++337a4497-5627-4a68-8543-06183122b0ae^firstPartyDomain=337a4497-5627-4a68-8543-06183122b0ae (3)

Now what? What needs to be overwritten/deleted?

@narcolepticinsomniac
Copy link
Member

Giving up didn't last long. IDK man, like I said, I'm not all that familiar. I tested briefly, and if I started FF with that config enabled, I saw the issue, but if I disabled and restarted, it was back to normal. Maybe the browser update screwed it up worse.

I only skimmed the thread, but it seemed to be saying to disable the config, close FF, and delete all the firstPartyDomain folders corresponding to the same ID. If you're worried, just move them somewhere else instead of deleting.

@cepvivaldi

This comment has been minimized.

@Mottie
Copy link
Member

Mottie commented Jul 18, 2019

What about looking at the time stamp on the database?

@b16r05
Copy link

b16r05 commented Jul 18, 2019

@Mottie

What do you mean? The SQlite file? You mean data modified or using an SQlite DB browser to look in?

moz-extension+++337a4497-5627-4a68-8543-06183122b0ae shows 17 July
moz-extension+++337a4497-5627-4a68-8543-06183122b0ae^userContextId=4294967295 16 July

@narcolepticinsomniac
Copy link
Member

itd bettet tham abusing technology intended for the disabled--or pretending to be a school for the blind to snoop...

I need to know the context for this sentence.

@tophf
Copy link
Member

tophf commented Oct 9, 2020

https://bugzil.la/1554805.

@tophf tophf closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants