-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changeset comments have individual links, but no button to grab them with #2796
Comments
i want to help with this issue, could you assign this to me |
Is this Issue still present or resolved? |
Yes, it is still present. |
I can't understand this Issue. Can you give me more clear idea about issue. |
When you hover over |
As far as I understand the <%= t comment.visible ? ".comment_by_html" : ".hidden_comment_by_html",
:comment => link_to(xxxxxx, "https://www.openstreetmap.org/changeset/#{changeset.id}##{comment.id}"),
:time_ago => friendly_date_ago(comment.created_at),
:user => link_to(comment.author.display_name, comment.author) %> ¹ It's difficult because the word Comment should still be translated in each language, so somehow it should keep the translations and add links to them. All in all, this seems a bit more complicated to me than a good first issue. |
@tomhughes Can the "good first issue" label be removed from this because of the above explanation? I got baited into seeing this issue by it. |
Yes and no. You don't have to consider how this works, you only need to make changes to en.yml and our translation team will take care of the rest.
I wouldn't do it quite like that, I would be more likely to make the time_ago into the permalink, just like here on github comments.
It's a reasonably isolated piece of code, it doesn't require any refactoring or other large-scale changes, so I still think it's reasonable as a good first issue. It might not be a good first issue for you, but that's no problem, there's plenty of other things to work on too! 😄 |
My bad!
@gravitystorm Ah, so just like this: #4789? |
No worries, we're here to help you get started and learn how everything works.
More or less! 😄 You'll want to use the path helpers rather than string interpolation into a fixed url, but we can cover this kind of thing in the PR review. Thanks for opening the PR. |
Here I link directly to a changeset comment.
But how did I figure out how?
With Chromium Inspector (F12). That's because I'm a computer wiz.
But for normal mappers, they should be able to get the link from somewhere in the
Comment from Nuerdensfields 24 minutes ago
sentence. But due to some bug, they can't!
The text was updated successfully, but these errors were encountered: