Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current sample config files has diverged from documentation #310

Open
amandasaurus opened this issue Mar 3, 2023 · 2 comments
Open

Current sample config files has diverged from documentation #310

amandasaurus opened this issue Mar 3, 2023 · 2 comments

Comments

@amandasaurus
Copy link
Contributor

While writing compile docs for Debian 12, I had to change many things from the old Ubuntu 20.04 instructions, because the sample config are differed. Even the github actions for this project do a hack to fix the mapnik path. For details on changes, see the commits on this PR

I'm unsure the solution. Dropping support for Ubuntu 20.04 in the sample configs might work.

I haven't looked at the CentOS or Red Hat documentaiton. They might have the same issue(s).

See also: #309 #295

@hummeltech
Copy link
Collaborator

hummeltech commented Mar 3, 2023

Hi @amandasaurus , thanks for the report. I recently added CMake build support to mod_tile, and I was just now thinking that we could also generate configuration files during the build process, similar to how the testing configuration files are generated here.

@hummeltech
Copy link
Collaborator

hummeltech commented Mar 5, 2023

Alright @amandasaurus, I think this pull request may fix most, if not all, of the issues you brought up. Part of the problem was that the build documentation files differed from any tested build methods, this has been mostly resolved by basing the updated build documentation files on a verifiable Docker-based build and test workflow. It's still not perfect, but at least you can also now see a full build and test in-action locally by running the two commands provided in the /docker/README.md file. As for the configuration files being out of date, I believe generating them with CMake is the way to go here and it will also provide a much better starting point for any package maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants