openstreetmap-tiles-update-expire and osm2pgsql 1.6.0 : --expire-tiles

[esgn]

Hi,

Stumbled upon this error in openstreetmap-tiles-update-expire with osm2pgsql

osm2pgsql version 1.6.0
ERROR: Minimum and maximum zoom level for tile expiry must be separated by '-'

-e$EXPIRY_METAZOOM:$EXPIRY_METAZOOM should be replaced by --expire-tiles "$EXPIRY_METAZOOM-$EXPIRY_METAZOOM" for the script to work with osm2pgsql 1.6.0

[lonvia]

That's funny. A colon was never an acceptable separator for osm2pgsql as far as I know. The main thing that has changed is that recent versions of osm2pgsql complain about the bad syntax.

[SomeoneElseOSM]

In addition to ^^ I suspect that relatively few people will actually use https://github.com/openstreetmap/mod_tile/blob/master/utils/openstreetmap-tiles-update-expire with osm2pgsql 1.6.0 , since osm2pgsql 1.4.2 or above fully supports osm2pgsql-replication and PyOsmium for replication, which doesn't require osmosis / Java.

Edit: Actually Debian 11 people wedded to the binaries in their distribution will be affected by this.

[joto]

In commits before 24488bfdaec2c432e33144ecb2688387253db37c the code was buggy and ignored everything after the colon if I see this correctly. Typical atoi() problem which ignores everything after the number. So this never worked correctly, because only the minzoom was set, not the maxzoom.

[ldeffenb]

In addition to ^^ I suspect that relatively few people will actually use https://github.com/openstreetmap/mod_tile/blob/master/utils/openstreetmap-tiles-update-expire with osm2pgsql 1.6.0 ,

Count me as one of the "few".