Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Portable Toilets" preset doesn't match the wiki #1148

Open
emersonveenstra opened this issue Mar 2, 2024 · 5 comments · May be fixed by #1159
Open

"Portable Toilets" preset doesn't match the wiki #1148

emersonveenstra opened this issue Mar 2, 2024 · 5 comments · May be fixed by #1159
Labels
bug Something isn't working
Milestone
v6.8

Comments

@emersonveenstra
Copy link
Contributor

Describe the bug
The preset for Portable Toilets adds the tag portable=yes, but that tag is not documented and has never been recommended on the amenity=toilets page, so it should probably be changed to toilets:disposal=tank to match the wiki page.
@emersonveenstra emersonveenstra added the bug Something isn't working label Mar 2, 2024
@tyrasd
Copy link
Member

tyrasd commented Mar 6, 2024

references of how this tag got into the tagging schema:

I agree that the use of the undocumented portable=yes tag is not great, but as far as I can see, toilets:disposal=tank is also not ideal because there exist also non-portable toilets with a tank, and there might also exist portable toilets which use other types of disposal (e.g. chemical, bucket, perhaps even flush, etc.).

I'm confused that toilets:type=mobile was apparently deprecated without a proper replacement. 🤔

@tyrasd tyrasd added the waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques label Mar 7, 2024
@emersonveenstra
Copy link
Contributor Author

toilets:disposal=tank is also not ideal because there exist also non-portable toilets with a tank, and there might also exist portable toilets which use other types of disposal

Sure, but since these toilets are not temporary (otherwise they shouldn't be mapped), I don't see what information is added by portable=yes

@tyrasd tyrasd added this to the v6.8 milestone Mar 13, 2024
@tyrasd
Copy link
Member

tyrasd commented Mar 13, 2024

Probably it would be best to just get rid of the "Portable Toilet" preset in favor of the regular Toilets preset. 🤔

tyrasd added a commit that referenced this issue Mar 13, 2024
@tyrasd
drop "Portable Toilets" preset
33f0457 
* rename generic amenity=toilets preset to "Toilets" (was: "Restroom"), as restroom is typically only used for indoor toilets, but the tag can also be used for outdoor ones
* rename field for "toilets" tag to "Restroom" (for the opposite reason as above)
* move alias "Water Closet" to "Flush Toilets" preset

fixes #1148
@tyrasd tyrasd linked a pull request Mar 13, 2024 that will close this issue
Open
@tyrasd tyrasd removed the waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques label Mar 13, 2024
@tyrasd
Copy link
Member

tyrasd commented Mar 13, 2024

I've created #1159 for this, where I also tweaked the labels of the toilet-related presets a bit. @emersonveenstra would you mind giving it a look if that would be OK in American English?

@emersonveenstra
Copy link
Contributor Author

looks good to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v6.8
Development

Successfully merging a pull request may close this issue.

drop "Portable Toilets" preset openstreetmap/id-tagging-schema
2 participants
@tyrasd @emersonveenstra