Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a geoscribble-notes layer #10204

Open
Zverik opened this issue Apr 15, 2024 · 4 comments
Open

Add a geoscribble-notes layer #10204

Zverik opened this issue Apr 15, 2024 · 4 comments

Comments

@Zverik
Copy link
Contributor

Zverik commented Apr 15, 2024

Description

There's a panel under the "Map Data" button, "Data Layers". It contains OpenStreetMap Notes, for example.

I recently have made a GeoScribble service that stores drawings and short notes made with the Every Door editor. They look like this

In JOSM I currently use these notes by adding a WMS layer. It works, but not the best way, since it creates a load on the server, and the text would be distorted when scaling.

The best way would be to add a new "GeoScribbles" data layer, which accesses /scribbles endpoint that returns all geometries and notes as json. And then display them on the map.

The layer doesn't have to be editable, it's just a digital walking papers thing. In the future we could add deleting obsolete drawings, but it's not important. I just want to see scribbles in the iD editor :)

Screenshots

No response

@tordans
Copy link
Collaborator

tordans commented May 3, 2024

@bhousel given your knowledge of both iD and Rapid, is facebook/Rapid#1372 something that can be ported to iD with reasonably effort or is this part of the code in Rapid that changed too much?

@bhousel
Copy link
Member

bhousel commented May 3, 2024

@bhousel given your knowledge of both iD and Rapid, is facebook/Rapid#1372 something that can be ported to iD with reasonably effort or is this part of the code in Rapid that changed too much?

The service code to fetch features from the server should be mostly reusable, and the rendering code to draw the shapes would be mostly different. But there are plenty of examples in iD's code that do similar things, so it should be pretty simple to implement.

@simonpoole
Copy link
Contributor

simonpoole commented May 7, 2024

@Zverik you should simply provide this (the geojson data) via a WFS service and WMS as a temp. solution for editors that don't support it. Add the later to ELI.

@Zverik
Copy link
Contributor Author

Zverik commented May 7, 2024

@simonpoole good idea! I totally forgot about ELI, made a pull request: osmlab/editor-layer-index#2312

GeoScribble already provides a WMS endpoint. Alas iD does not support custom overlay layers (see #9280).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants