Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release as Electron app #10162

Open
verhovsky opened this issue Mar 15, 2024 · 4 comments
Open

Release as Electron app #10162

verhovsky opened this issue Mar 15, 2024 · 4 comments

Comments

@verhovsky
Copy link

verhovsky commented Mar 15, 2024

Packaging iD as an Electron application has two benefits I can think of (besides the obvious)

  1. swiping back with two fingers on a touchpad shouldn't act as a back button like it does on macos. i've lost data because of this
  2. you can have more undo history because localsessionstorage is 50MB instead of 10MB. you could also write to disk and get effectively unlimited history
@k-yle
Copy link
Contributor

k-yle commented Mar 16, 2024

  1. This annoying behaviour can be disabled in settings for all apps, or just for chrome
  2. We could easily fix this by using IndexedDB instead of localStorage, then there would be effectively no size limit. Using IndexedDB would also improve performance, since we no longer need to call JSON.stringify on an a huge object everytime you drag a node. Incidentally, that's one of the biggest performance bottlenecks that I've noticed in iD

@verhovsky
Copy link
Author

I'm not going to disable it for Chrome because I like it on all websites except iD.

@matkoniecz
Copy link
Contributor

(besides the obvious)

Which one is obvious for you?

@verhovsky
Copy link
Author

verhovsky commented Apr 5, 2024

less taps to open, less data to load

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants