Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support on windows #61

Closed
wants to merge 42 commits into from
Closed

Add support on windows #61

wants to merge 42 commits into from

Conversation

NobodyXu
Copy link
Member

Fixed #46

@NobodyXu NobodyXu added the enhancement New feature or request label Mar 11, 2022
@NobodyXu NobodyXu added this to the windows-support milestone Mar 11, 2022
@NobodyXu NobodyXu requested a review from jonhoo March 11, 2022 08:19
@NobodyXu NobodyXu self-assigned this Mar 11, 2022
@jonhoo
Copy link
Collaborator

jonhoo commented Mar 11, 2022

This change is Reviewable

@NobodyXu
Copy link
Member Author

The Windows CI does not support running docker container, so I didn't run the integration tests on Windows CI.

@NobodyXu
Rm cfg(unix) requirement for the crate
65a99e8 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Only enable feature native-mux on unix
7e16a54 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Enable the current mod stdio only on unix
cefcd0f 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Enable unix-only crates only on unix
97b1951 
 - tempdir
 - dirs
 - libc
 - once_cell
 - io-lifetimes
 - tokio-pipe

are now only enabled on unix.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix compilation of feature native-mux on windows
699cef2 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix integration tests on windows
1d8ad8b 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix feature native-mux for all non-unix platforms
1f63d1a 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Impl stdio/windows.rs
b2c2e30 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Rename process_impl/session.rs to session-unix.rs
ca33611 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix unix-only function/field in SessionBuilder
049a6a2 
by marking them `cfg(unix)` or `cfg(not(windows))`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Impl process_impl/session-windows.rs
5926a00 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Simplify SessionBuilder::apply_options
d6cfd02 
Accept `tokio::proess::Command` instead of `std::process::Command`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Run workflow test on windows
9a7a999 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Update crate doc for windows support
706c830 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Revert changes made to workflow test
200208f 
Since Windows does not support container.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Enable workflow os-check to run on windows-latest
949c8a9 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix impl_from_impl_child_io! in stdio/windows.rs
04df280 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix undeclared crates in windows CI build
8408e35 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix bug in impl_child_stdio! in stdio/windows.rs
469dfac 
I copied it from `stdio/unix.rs` and I forgot to change `RawFd` to
`RawHandle`.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix unused import in lib.rs in windows CI
c7c1b20 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix unused imports in mod builder in windows CI
5effcc2 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix unused imports in process_impl/session-windows.rs
2428948 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix unused imports in port_forwarding in win CI
1c7526e 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Enable Socket::UnixSocket for windows
111418e 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix SessionBuilder::connect for win
4c9029c 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix win impl Session::parse_stderr
c2d29bd 
Remove unused parameter `&self`.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Refactor session-windows.rs: Rm fn parse_stderr
f6d0c7e 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Rm unnecessary mut in win impl of Session::close
5ba0379 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix SessionBuilder::apply_options: Make it pub(crate)
8276988 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix err parsing in win impl of Session::request_port_forward
494ab04 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
FIx impl_try_from_child_io_for_stdio in stdio/windows.rs
46a31e9 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix code style in process_impl/session-windows.rs
4889340 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix SessionBuilder::connect: Fix win impl
69252fe 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix FromRawHandle for Stdio in Windows impl
6b6dc0d 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix unused Error::interpret_ssh_error in Win CI
94943ca 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Rm unused func Session::check in Win impl
4afaf42 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Add dep tempfile to dev-dependencies
efc14c4 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix examples/native-mux_tsp.rs in Win CI
bb1c9b0 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix tests/openssh.rs on Win CI
d996c3e 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix unused imports in tests/openssh.rs in Win CI
3dd6688 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix examples/native-mux_tsp.rs in Win CI
c94729b 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix error::tests::parse_error: Only execute on Unix
272299f 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@jonhoo
Copy link
Collaborator

jonhoo commented Mar 26, 2022

While I appreciate the work you've done on this, I don't think this is something I want to merge. We don't have a reliable way to test it in CI, it introduces a lot of conditional compilation, it has a completely different execution model (which will be unexpected for users), and it will become unsupported again if we eventually move to just supporting the native mux.

@NobodyXu
Copy link
Member Author

While I appreciate the work you've done on this, I don't think this is something I want to merge. We don't have a reliable way to test it in CI, it introduces a lot of conditional compilation, it has a completely different execution model (which will be unexpected for users), and it will become unsupported again if we eventually move to just supporting the native mux.

I have to agree, as this makes this crate significantly more complicated and I haven't figure out how to run sshd on windows in the CI yet.

IMHO it will be much easier if unix socket in windows supports passing file handler/fd.

@NobodyXu NobodyXu closed this Mar 27, 2022
@NobodyXu NobodyXu deleted the support-windows branch March 27, 2022 01:49
@NobodyXu NobodyXu mentioned this pull request Apr 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo Awaiting requested review from jonhoo

Assignees

@NobodyXu NobodyXu

Labels
enhancement New feature or request
Milestone
windows-support
Development

Successfully merging this pull request may close these issues.

Unable to establish connection on Windows 11
2 participants
@NobodyXu @jonhoo